Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded AMIs and AZs in network interface test #14330

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 23, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12994

Release note for CHANGELOG:

NONE

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSENI_computedIPs (32.93s)
--- PASS: TestAccAWSENI_sourceDestCheck (33.16s)
--- PASS: TestAccAWSENI_disappears (36.21s)
--- PASS: TestAccAWSENI_basic (37.60s)
--- PASS: TestAccAWSENI_updatedDescription (60.09s)
--- PASS: TestAccAWSENI_PrivateIpsCount (83.69s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (116.94s)
--- PASS: TestAccAWSENI_attached (122.62s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSENI_computedIPs (38.01s)
--- PASS: TestAccAWSENI_sourceDestCheck (38.79s)
--- PASS: TestAccAWSENI_disappears (40.66s)
--- PASS: TestAccAWSENI_basic (42.11s)
--- PASS: TestAccAWSENI_updatedDescription (68.26s)
--- PASS: TestAccAWSENI_PrivateIpsCount (100.21s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (111.35s)
--- PASS: TestAccAWSENI_attached (123.45s)

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 23, 2020
@YakDriver YakDriver changed the title Remove hardcoded AMIs and AZs Remove hardcoded AMIs and AZs in network interface test Jul 23, 2020
@YakDriver YakDriver marked this pull request as ready for review July 23, 2020 20:41
@YakDriver YakDriver requested a review from a team July 23, 2020 20:41
@YakDriver
Copy link
Member Author

This isn't nearly as bad as it looks. Most of the changes are formatting. The config was all over the place so felt a fix was in order.

@bflad bflad self-assigned this Jul 24, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One consideration, otherwise looks great 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSENI_computedIPs (15.68s)
--- PASS: TestAccAWSENI_sourceDestCheck (16.53s)
--- PASS: TestAccAWSENI_basic (17.11s)
--- PASS: TestAccAWSENI_disappears (17.07s)
--- PASS: TestAccAWSENI_updatedDescription (25.84s)
--- PASS: TestAccAWSENI_PrivateIpsCount (39.73s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (77.83s)
--- PASS: TestAccAWSENI_attached (112.63s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSENI_sourceDestCheck (14.85s)
--- PASS: TestAccAWSENI_computedIPs (15.30s)
--- PASS: TestAccAWSENI_disappears (16.68s)
--- PASS: TestAccAWSENI_basic (17.63s)
--- PASS: TestAccAWSENI_updatedDescription (20.56s)
--- PASS: TestAccAWSENI_PrivateIpsCount (27.02s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (83.37s)
--- PASS: TestAccAWSENI_attached (98.80s)

aws/resource_aws_network_interface_test.go Show resolved Hide resolved
@YakDriver YakDriver added this to the v3.0.0 milestone Jul 24, 2020
@YakDriver YakDriver merged commit f97954f into master Jul 24, 2020
@YakDriver YakDriver deleted the td-hardami-eni branch July 24, 2020 22:31
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 24, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants