Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded AMIs and AZs from autoscaling schedule #14325

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Remove hardcoded AMIs and AZs from autoscaling schedule #14325

merged 1 commit into from
Jul 23, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 23, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12994

Release note for CHANGELOG:

NONE

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSAutoscalingSchedule_basic (131.55s)
--- PASS: TestAccAWSAutoscalingSchedule_negativeOne (140.23s)
--- PASS: TestAccAWSAutoscalingSchedule_zeroValues (140.44s)
--- PASS: TestAccAWSAutoscalingSchedule_recurrence (141.04s)
--- PASS: TestAccAWSAutoscalingSchedule_disappears (141.65s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSAutoscalingSchedule_negativeOne (136.59s)
--- PASS: TestAccAWSAutoscalingSchedule_basic (137.85s)
--- PASS: TestAccAWSAutoscalingSchedule_recurrence (146.76s)
--- PASS: TestAccAWSAutoscalingSchedule_zeroValues (147.04s)
--- PASS: TestAccAWSAutoscalingSchedule_disappears (147.44s)

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 23, 2020
@breathingdust breathingdust mentioned this pull request Jul 23, 2020
Closed
17 tasks
@YakDriver YakDriver marked this pull request as ready for review July 23, 2020 17:13
@YakDriver YakDriver requested a review from a team July 23, 2020 17:13
bflad
bflad approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSAutoscalingSchedule_disappears (127.57s)
--- PASS: TestAccAWSAutoscalingSchedule_zeroValues (156.78s)
--- PASS: TestAccAWSAutoscalingSchedule_negativeOne (166.69s)
--- PASS: TestAccAWSAutoscalingSchedule_recurrence (167.18s)
--- PASS: TestAccAWSAutoscalingSchedule_basic (168.19s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSAutoscalingSchedule_negativeOne (132.92s)
--- PASS: TestAccAWSAutoscalingSchedule_disappears (133.41s)
--- PASS: TestAccAWSAutoscalingSchedule_recurrence (133.59s)
--- PASS: TestAccAWSAutoscalingSchedule_basic (133.73s)
--- PASS: TestAccAWSAutoscalingSchedule_zeroValues (134.49s)

@bflad
Copy link
Contributor

bflad commented Jul 23, 2020

(sorry for the errant comment about AZ selection, was originally going to post it in this review but asked in the other one 😅 )

@YakDriver YakDriver merged commit b5e1bf3 into master Jul 23, 2020
@YakDriver YakDriver added this to the v3.0.0 milestone Jul 23, 2020
@YakDriver YakDriver deleted the td-hardami-asg-sched branch July 23, 2020 20:37
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 23, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @bflad