Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/neptune: Remove deprecated (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() #12458

Merged
merged 1 commit into from
Apr 1, 2020

Commits on Mar 19, 2020

  1. service/neptune: Remove deprecated (helper/schema.ResourceData).Parti…

    …al() and (helper/schema.ResourceData).SetPartial()
    
    Reference: #12083
    Reference: #12087
    
    Previously:
    
    ```
    aws/resource_aws_neptune_cluster.go:597:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster.go:684:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster_instance.go:384:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster_instance.go:390:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster_instance.go:396:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster_instance.go:402:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster_instance.go:451:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster_parameter_group.go:185:2: R007: deprecated (schema.ResourceData).Partial
    aws/resource_aws_neptune_cluster_parameter_group.go:226:4: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster_parameter_group.go:237:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_cluster_parameter_group.go:240:2: R007: deprecated (schema.ResourceData).Partial
    aws/resource_aws_neptune_event_subscription.go:209:2: R007: deprecated (schema.ResourceData).Partial
    aws/resource_aws_neptune_event_subscription.go:265:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_event_subscription.go:266:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_event_subscription.go:267:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_event_subscription.go:268:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_event_subscription.go:278:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_event_subscription.go:320:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_event_subscription.go:323:2: R007: deprecated (schema.ResourceData).Partial
    aws/resource_aws_neptune_parameter_group.go:100:2: R007: deprecated (schema.ResourceData).Partial
    aws/resource_aws_neptune_parameter_group.go:101:2: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_parameter_group.go:102:2: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_parameter_group.go:103:2: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_parameter_group.go:104:2: R007: deprecated (schema.ResourceData).Partial
    aws/resource_aws_neptune_parameter_group.go:181:2: R007: deprecated (schema.ResourceData).Partial
    aws/resource_aws_neptune_parameter_group.go:259:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_parameter_group.go:269:3: R008: deprecated (schema.ResourceData).SetPartial
    aws/resource_aws_neptune_parameter_group.go:272:2: R007: deprecated (schema.ResourceData).Partial
    aws/resource_aws_neptune_subnet_group.go:195:3: R008: deprecated (schema.ResourceData).SetPartial
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSNeptuneCluster_backupsUpdate (297.92s)
    --- PASS: TestAccAWSNeptuneCluster_basic (168.78s)
    --- PASS: TestAccAWSNeptuneCluster_deleteProtection (212.60s)
    --- PASS: TestAccAWSNeptuneCluster_encrypted (175.61s)
    --- PASS: TestAccAWSNeptuneCluster_iamAuth (193.62s)
    --- PASS: TestAccAWSNeptuneCluster_kmsKey (195.57s)
    --- PASS: TestAccAWSNeptuneCluster_namePrefix (154.44s)
    --- PASS: TestAccAWSNeptuneCluster_tags (209.12s)
    --- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (254.53s)
    --- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (233.15s)
    --- PASS: TestAccAWSNeptuneCluster_updateIamRoles (195.20s)
    
    --- PASS: TestAccAWSNeptuneClusterInstance_basic (1755.23s)
    --- PASS: TestAccAWSNeptuneClusterInstance_generatedName (785.56s)
    --- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (835.57s)
    --- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (807.49s)
    --- PASS: TestAccAWSNeptuneClusterInstance_withaz (925.05s)
    --- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (783.88s)
    
    --- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (17.40s)
    --- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (17.46s)
    --- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (17.68s)
    --- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (20.77s)
    --- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (31.24s)
    --- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (64.82s)
    
    --- PASS: TestAccAWSNeptuneEventSubscription_basic (150.00s)
    --- PASS: TestAccAWSNeptuneEventSubscription_withCategories (124.64s)
    --- PASS: TestAccAWSNeptuneEventSubscription_withPrefix (123.58s)
    --- PASS: TestAccAWSNeptuneEventSubscription_withSourceIds (97.81s)
    
    --- PASS: TestAccAWSNeptuneParameterGroup_basic (28.51s)
    --- PASS: TestAccAWSNeptuneParameterGroup_Description (22.30s)
    --- PASS: TestAccAWSNeptuneParameterGroup_Parameter (114.91s)
    --- PASS: TestAccAWSNeptuneParameterGroup_Tags (60.91s)
    
    --- PASS: TestAccAWSNeptuneSubnetGroup_basic (46.02s)
    --- PASS: TestAccAWSNeptuneSubnetGroup_generatedName (49.96s)
    --- PASS: TestAccAWSNeptuneSubnetGroup_namePrefix (48.39s)
    --- PASS: TestAccAWSNeptuneSubnetGroup_updateDescription (76.13s)
    ```
    bflad committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    c75a589 View commit details
    Browse the repository at this point in the history