Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Fix and enable tfproviderlint S031, S032, and S033 #12234

Merged
merged 2 commits into from
Mar 10, 2020

Commits on Mar 3, 2020

  1. provider: Fix and enable tfproviderlint S031, S032, and S033

    Reference: #12087
    Reference: #11869 (fix and enable S031)
    Reference: #11870 (fix and enable S032)
    Reference: #11871 (fix and enable S033)
    
    Previously:
    
    ```
    aws/data_source_aws_cloudhsm2_cluster.go:38:28: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_dynamodb_table.go:149:11: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_dynamodb_table.go:192:30: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_efs_file_system.go:62:24: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_eks_cluster.go:23:29: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_eks_cluster.go:89:18: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_elastic_beanstalk_application.go:29:28: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_elb.go:27:19: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_elb.go:80:20: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lambda_function.go:130:19: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lambda_function.go:144:22: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lambda_function.go:31:26: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lambda_function.go:49:14: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lambda_function.go:81:18: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lambda_layer_version.go:34:27: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lb.go:74:19: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lb_target_group.go:73:18: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_lb_target_group.go:95:20: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_mq_broker.go:131:37: S031: schema should not only enable Computed and configure MaxItems
    aws/data_source_aws_mq_broker.go:37:21: S031: schema should not only enable Computed and configure MaxItems
    aws/resource_aws_api_gateway_account.go:29:25: S031: schema should not only enable Computed and configure MaxItems
    aws/resource_aws_cloudhsm2_cluster.go:64:28: S031: schema should not only enable Computed and configure MaxItems
    aws/resource_aws_eks_cluster.go:47:29: S031: schema should not only enable Computed and configure MaxItems
    
    aws/data_source_aws_lambda_function.go:31:26: S032: schema should not only enable Computed and configure MinItems
    
    aws/data_source_aws_cloudformation_stack.go:22:21: S033: schema should not only enable Computed and configure StateFunc
    aws/data_source_aws_dynamodb_table.go:140:24: S033: schema should not only enable Computed and configure StateFunc
    aws/data_source_aws_rds_cluster.go:120:36: S033: schema should not only enable Computed and configure StateFunc
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSAPIGatewayAccount_basic (116.01s)
    
    --- PASS: TestAccAWSCloudFormationStack_dataSource_basic (74.98s)
    --- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (74.96s)
    
    --- PASS: TestAccAWSCloudHsm2Cluster_basic (292.57s)
    --- PASS: TestAccAWSCloudHsm2Cluster_Tags (340.49s)
    
    --- PASS: TestAccAWSEksCluster_basic (1204.53s)
    --- PASS: TestAccAWSEksCluster_Logging (1300.14s)
    --- PASS: TestAccAWSEksCluster_Tags (1280.00s)
    --- PASS: TestAccAWSEksCluster_Version (2452.84s)
    --- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (2435.44s)
    --- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1720.71s)
    --- PASS: TestAccAWSEksCluster_VpcConfig_PublicAccessCidrs (1587.49s)
    --- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1186.78s)
    --- PASS: TestAccAWSEksClusterDataSource_basic (1239.69s)
    
    --- PASS: TestAccAwsElasticBeanstalkApplicationDataSource_basic (21.56s)
    
    --- PASS: TestAccDataSourceAWSALBTargetGroup_basic (175.08s)
    
    --- PASS: TestAccDataSourceAwsDynamoDbTable_basic (44.81s)
    
    --- PASS: TestAccDataSourceAwsEfsFileSystem_id (29.06s)
    --- PASS: TestAccDataSourceAwsEfsFileSystem_name (28.39s)
    
    --- PASS: TestAccDataSourceAWSELB_basic (53.87s)
    
    --- PASS: TestAccDataSourceAWSLambdaFunction_alias (65.51s)
    --- PASS: TestAccDataSourceAWSLambdaFunction_basic (49.09s)
    --- PASS: TestAccDataSourceAWSLambdaFunction_environment (59.75s)
    --- PASS: TestAccDataSourceAWSLambdaFunction_layers (71.91s)
    --- PASS: TestAccDataSourceAWSLambdaFunction_version (41.88s)
    --- PASS: TestAccDataSourceAWSLambdaFunction_vpc (1838.06s)
    --- PASS: TestAccDataSourceAWSLambdaLayerVersion_basic (19.83s)
    --- PASS: TestAccDataSourceAWSLambdaLayerVersion_runtime (46.22s)
    --- PASS: TestAccDataSourceAWSLambdaLayerVersion_version (35.61s)
    
    --- PASS: TestAccDataSourceAWSLB_basic (211.76s)
    
    --- PASS: TestAccDataSourceAWSMqBroker_basic (1232.73s)
    
    --- PASS: TestAccDataSourceAWSRDSCluster_basic (135.85s)
    
    --- PASS: TestAccDataSourceCloudHsm2Cluster_basic (267.05s)
    ```
    bflad committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    e90be4d View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Configuration menu
    Copy the full SHA
    a5b56c2 View commit details
    Browse the repository at this point in the history