Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PCI standard examples and docs #12090

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Add PCI standard examples and docs #12090

merged 2 commits into from
Mar 19, 2020

Conversation

mwarkentin
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Notes

ARN taken from AWS CLI run against us-east-1:

% aws securityhub describe-standards
{
    "Standards": [
        {
            "StandardsArn": "arn:aws:securityhub:::ruleset/cis-aws-foundations-benchmark/v/1.2.0",
            "Name": "CIS AWS Foundations Benchmark v1.2.0",
            "Description": "The Center for Internet Security (CIS) AWS Foundations Benchmark v1.2.0 is a set of security configuration best practices for AWS. This Security Hub standard automatically checks for your compliance readiness against a subset of CIS requirements."
        },
        {
            "StandardsArn": "arn:aws:securityhub:us-east-1::standards/pci-dss/v/3.2.1",
            "Name": "PCI DSS v3.2.1",
            "Description": "The Payment Card Industry Data Security Standard (PCI DSS) v3.2.1 is an information security standard for entities that store, process, and/or transmit cardholder data. This Security Hub standard automatically checks for your compliance readiness against a subset of PCI DSS requirements."
        }
    ]
}

I have not tested the import functionality yet.

@mwarkentin mwarkentin requested a review from a team February 19, 2020 18:40
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/securityhub Issues and PRs that pertain to the securityhub service. labels Feb 19, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor update and we can get this in, thanks, @mwarkentin 👍

website/docs/r/securityhub_standards_subscription.markdown Outdated Show resolved Hide resolved
@bflad bflad added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 17, 2020
@bflad bflad self-assigned this Mar 17, 2020
Co-Authored-By: Brian Flad <bflad417@gmail.com>
@mwarkentin
Copy link
Contributor Author

@bflad thanks, pulled in the suggestion!

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 18, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mwarkentin 🚀

@bflad bflad added this to the v2.54.0 milestone Mar 19, 2020
@bflad bflad merged commit ce824da into hashicorp:master Mar 19, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@mwarkentin mwarkentin deleted the patch-2 branch March 23, 2020 00:50
@mwarkentin mwarkentin restored the patch-2 branch March 23, 2020 00:50
@mwarkentin mwarkentin deleted the patch-2 branch March 23, 2020 00:50
@mwarkentin mwarkentin restored the patch-2 branch March 23, 2020 00:54
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/securityhub Issues and PRs that pertain to the securityhub service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants