Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/resource/aws_eks_node_group: Note max items restriction for instance_types argument #11457

Merged
merged 1 commit into from
Jan 10, 2020
Merged

docs/resource/aws_eks_node_group: Note max items restriction for instance_types argument #11457

merged 1 commit into from
Jan 10, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 2, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11414
Reference: https://github.com/terraform-providers/terraform-provider-aws/blob/65535967248cd91a87e4e48e8e75380bc5332526/aws/resource_aws_eks_node_group.go#L61-L70

Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A

@bflad bflad requested a review from a team January 2, 2020 15:31
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. labels Jan 2, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 2, 2020
@bflad bflad mentioned this pull request Jan 2, 2020
Closed
ryndaniels
ryndaniels approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bflad bflad added this to the v2.45.0 milestone Jan 10, 2020
@bflad bflad merged commit 0d62930 into master Jan 10, 2020
@bflad bflad deleted the d-aws_eks_node_group-instance_types-maxitems branch January 10, 2020 17:43
@ghost
Copy link

ghost commented Jan 17, 2020

This has been released in version 2.45.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.45.0
Development

Successfully merging this pull request may close these issues.

aws_eks_node_group accepts instance_types, while EKS only allows one type
2 participants
@bflad @ryndaniels