Prototype exposing cty.Values from ResourceData. #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
force-pushed
the
paddy_resourcedata_cty
branch
from
71bc10b
to
6fb4a1a
Compare
paddycarver
force-pushed
the
paddy_resourcedata_cty
branch
from
92b2e1f
to
352c0d2
Compare
paddycarver
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Sep 8, 2021
Supporting tests for hashicorp/terraform-plugin-sdk#802. Testing the new cty stuff hanging off the ResourceData and ResourceDiff types.
paddycarver
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Sep 8, 2021
Supporting tests for hashicorp/terraform-plugin-sdk#802. Testing the new cty stuff hanging off the ResourceData and ResourceDiff types.
|
Supported by hashicorp/terraform-provider-corner#29. |
paddycarver
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Sep 8, 2021
Supporting tests for hashicorp/terraform-plugin-sdk#802. Testing the new cty stuff hanging off the ResourceData and ResourceDiff types.
paddycarver
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Sep 8, 2021
Supporting tests for hashicorp/terraform-plugin-sdk#802. Testing the new cty stuff hanging off the ResourceData and ResourceDiff types.
bflad
approved these changes
Sep 10, 2021
bflad
pushed a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Sep 28, 2021
Supporting tests for hashicorp/terraform-plugin-sdk#802. Testing the new cty stuff hanging off the ResourceData and ResourceDiff types.
bflad
pushed a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Sep 28, 2021
Supporting tests for hashicorp/terraform-plugin-sdk#802. Testing the new cty stuff hanging off the ResourceData and ResourceDiff types.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #793.
We actually create a
terraform.InstanceStatewhen handling the gRPC methods, and then a ResourceData is created from that. So, like with ProviderMeta functionality (#405) we're following the same path and threading our cty values through the instance state.This still needs unit tests.