Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/logging: Update test Content-Type header to match terraform.io change #1045

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 1, 2022

Reference: https://github.com/hashicorp/terraform-plugin-sdk/actions/runs/2970165412

Previously:

--- FAIL: TestNewLoggingHTTPTransport (0.27s)
    /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/logging/logging_http_transport_test.go:93: Unexpected value for field "Content-Type"; expected "text/html", got "text/html; charset=utf-8"

Double checking the current situation with curl:

$ curl -I -s https://www.terraform.io | grep -i content-type
content-type: text/html; charset=utf-8

… change

Reference: https://github.com/hashicorp/terraform-plugin-sdk/actions/runs/2970165412

Previously:

```
--- FAIL: TestNewLoggingHTTPTransport (0.27s)
    /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/logging/logging_http_transport_test.go:93: Unexpected value for field "Content-Type"; expected "text/html", got "text/html; charset=utf-8"
```

Double checking the current situation with `curl`:

```console
$ curl -I -s https://www.terraform.io | grep -i content-type
content-type: text/html; charset=utf-8
```
@bflad bflad requested a review from a team as a code owner September 1, 2022 12:31
@bflad bflad added this to the v2.22.0 milestone Sep 2, 2022
@bflad bflad merged commit a5eecf7 into main Sep 2, 2022
@bflad bflad deleted the bflad/logging-content-type-test-fix branch September 2, 2022 10:20
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants