Skip to content

Commit

Permalink
tf5muxserver+tf6muxserver: Remove resource schema caching
Browse files Browse the repository at this point in the history
Reference: #168

This change removes the `GetProviderSchema` RPC-based caching logic in `NewMuxServer` and directly calls the underlying providers within that RPC. To fully support the removal of resource schema caching, the `PlanResourceChange` logic for checking the `ProposedNewState` data for a destroy plan was optimized to no longer require decoding the data with the type information.

For larger scale providers (either number of resources and/or resources with large schemas), this should reduce resident memory utilization with little performance penalty.
  • Loading branch information
bflad committed Jun 28, 2023
1 parent 2d33d1e commit 111033e
Show file tree
Hide file tree
Showing 37 changed files with 429 additions and 665 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/BUG FIXES-20230627-134839.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: BUG FIXES
body: 'tf5muxserver: Removed unnecessary resource schema caching, which reduces resident
memory utilization'
time: 2023-06-27T13:48:39.01979-04:00
custom:
Issue: "168"
6 changes: 6 additions & 0 deletions .changes/unreleased/BUG FIXES-20230627-134907.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: BUG FIXES
body: 'tf6muxserver: Removed unnecessary resource schema caching, which reduces resident
memory utilization'
time: 2023-06-27T13:49:07.303269-04:00
custom:
Issue: "168"
31 changes: 0 additions & 31 deletions internal/tf5dynamicvalue/is_null.go

This file was deleted.

154 changes: 0 additions & 154 deletions internal/tf5dynamicvalue/is_null_test.go

This file was deleted.

31 changes: 0 additions & 31 deletions internal/tf6dynamicvalue/is_null.go

This file was deleted.

154 changes: 0 additions & 154 deletions internal/tf6dynamicvalue/is_null_test.go

This file was deleted.

Loading

0 comments on commit 111033e

Please sign in to comment.