Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error messaging for HCP incompatible plugin builds #12800

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Update error messaging for HCP incompatible plugin builds #12800

merged 2 commits into from
Jan 25, 2024

Conversation

nywilken
Copy link
Contributor

No description provided.

@nywilken nywilken requested a review from a team as a code owner January 25, 2024 15:13
@nywilken nywilken added the backport/1.10.x Backport PR changes to `release/1.10.x` label Jan 25, 2024
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just left a nit on the error message, but aside from that LGTM

command/build.go Outdated Show resolved Hide resolved
@nywilken @lbajolet-hashicorp
Update command/build.go
abed2f6 
Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>
@nywilken nywilken merged commit 12b8c88 into main Jan 25, 2024
11 checks passed
@hc-github-team-packer hc-github-team-packer mentioned this pull request Jan 25, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devashish-patel devashish-patel devashish-patel approved these changes

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Assignees
No one assigned
Labels
backport/1.10.x Backport PR changes to `release/1.10.x` enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nywilken @devashish-patel @lbajolet-hashicorp