Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third-party plugin imports #11912

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Jul 29, 2022

  • packer-plugin-digitalocean: Update module import path
    The DigitalOcean Packer plugin is now maintained by the Digital Ocean team.
    New release for this plugin are available at https://github.com/digitalocean/packer-plugin-digitalocean.
    Existing references to the plugin will continue to work but
    user's are advised to update the required_plugins block to use the new plugin source address.
required_plugins {
    digitalocean = {
     source =  "github.com/digitalocean/digitalocean"
     version = ">=1.0.8"
    }
}
  • packer-plugin-outscale: Remove bundled plugin
    The Outscale plugin has been maintained by the Outscale team for some time now.
    In order to ensure users the most up to date version of the plugin it has been removed from Packer.
    To install the latest version of the plugin please run packer plugins install github.com/outscale/outscale.

  • packer-plugin-scaleway: Remove bundled plugin
    The Scaleway plugin has been maintained by the Scaleway team for some time now.
    In order to ensure users the most up to date version of the plugin it has been removed from Packer.
    To install the latest version of the plugin please run packer plugins install github.com/scaleway/scaleway.

@nywilken nywilken requested a review from a team as a code owner July 29, 2022 14:03
Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!!

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have one question on a dependency, other than that LGTM!

Regarding Scaleway, I noticed your commit message mentions installing it with packer plugins install github.com/outscale/outscale, I imagine that's a typo?

@@ -96,8 +95,6 @@ require (
github.com/hashicorp/packer-plugin-vmware v1.0.7
github.com/hashicorp/packer-plugin-vsphere v1.0.5
github.com/hashicorp/packer-plugin-yandex v1.1.1
github.com/prometheus/common v0.9.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one looks off, is this a transitive dependency that's removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a side effect of running go mod tidy it is possible that it came in with the recent hcp-sdk-go changes.

@nywilken
Copy link
Contributor Author

Just have one question on a dependency, other than that LGTM!

Regarding Scaleway, I noticed your commit message mentions installing it with packer plugins install github.com/outscale/outscale, I imagine that's a typo?

@lbajolet-hashicorp good catch I updated the comment. I will add them as notes in the CHANGELOG

@nywilken nywilken merged commit e3ad29d into main Jul 29, 2022
@nywilken nywilken deleted the nywilken/cleanup-bundled-plugins branch July 29, 2022 15:45
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants