Fix docker build for workflow_call events #11603
Conversation
mdeggies
requested review from
a team,
samsalisbury,
modrake and
nywilken
and removed request for
a team
.github/workflows/build.yml
Outdated
| @@ -245,7 +245,7 @@ jobs: | |||
| matrix: | |||
| arch: ["arm", "arm64", "386", "amd64"] | |||
| env: | |||
| repo: ${{ github.event.repository.name }} | |||
| repo: "${{ env.PKG_NAME }}" | |||
There was a problem hiding this comment.
This clearly works correctly in this workflow, I just wonder if the pattern could be confusing in other repos. The name PKG_NAME doesn't necessarily map to repo. The helloworld app does use the repository name for its docker tags, but I'm also questioning that now because the mapping is coincidental for some repos rather than something we can always rely on.
I would be tempted here to either replace all the env.repo template values in tags below with env.PKG_NAME, or else to just hard-code packer in the tags. But maybe this is something better discussed as a group first, and updated in the helloworld apps before trying to roll out a new pattern on the fly.
There was a problem hiding this comment.
Thanks, Sam! I just updated this to use env.PKG_NAME instead of env.repo for the docker build job. Nightly releases aren't in use by any other teams yet -- this was created specifically for packer to have feature parity with existing code in packer-releases -- but there's an open PR in the HelloWorld project discussing adding this support across products. Feel free to comment there if you have suggestions!
| @@ -245,7 +245,6 @@ jobs: | |||
| matrix: | |||
| arch: ["arm", "arm64", "386", "amd64"] | |||
| env: | |||
| repo: ${{ github.event.repository.name }} | |||
There was a problem hiding this comment.
This looks good to me . To confirm the issue here is that this event information is not available via scheduled actions, correct?
There was a problem hiding this comment.
Yes! That's it. On workflow_call events, the github.event.repository.name isn't available, so we need to reference something else.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Related to #11601 (comment), the same change needs to be made for the docker build job to work for nightly build/releases.