Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: remove old docs targets #164

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Commits on Sep 21, 2023

  1. makefile: remove old docs targets

    Since we moved the docs to integrations, we don't need to build the
    docs.zip file anymore, and to make it easier for plugin developers we
    move the logic for building the new .docs directory to the `generate'
    Makefile target.
    lbajolet-hashicorp committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8f18c88 View commit details
    Browse the repository at this point in the history
  2. .github: remove ensure-docs-compiled workflow

    Since the workflow relies on the build-docs target existing in the
    Makefile to ensure we don't commit a change without calling it, and
    since we removed it in the previous commit to fold it in generate, we
    don't need it anymore so we can remove it.
    
    Since the `make generate' call is already required if modifying the
    docs, and we check that during validate, this is safe to remove.
    lbajolet-hashicorp committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9e71183 View commit details
    Browse the repository at this point in the history
  3. Makefile: remove superfluous renderdocs

    Since we have merged `build-docs' with `generate', we don't need to
    manually invoke `packer-sdc renderdocs' before the old build-docs.
    lbajolet-hashicorp committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0eaeed4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. goreleaser: don't rely on ci-make-docs

    Since the ci-make-docs target is no longer part of the Makefile, we
    cannot rely on it for making the latest docs, and therefore we must
    remove that from the goreleaser file too.
    lbajolet-hashicorp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1518a91 View commit details
    Browse the repository at this point in the history
  2. goreleaser: don't include docs.zip in release

    The docs.zip file should not be part of the release as it is no longer
    generated nor required to build the docs for a plugin.
    
    Keeping this in the releaser config caused the release to fail before
    the artifacts were updated, leading to a corrupted release.
    lbajolet-hashicorp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c3545d1 View commit details
    Browse the repository at this point in the history