Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #122

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Fix lint errors #122

merged 2 commits into from
Sep 23, 2022

Conversation

lbajolet-hashicorp
Copy link
Contributor

Running golangci-lint on the repository returns some errors, so we fix them in this PR.

The artifact returned by the post-processors are necessarily
packersdk.Artifact instances, hence the tests for the return type are
marked as unnecessary by golangci-lint.

To silence these errors, we remove these type checks.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner September 23, 2022 14:09
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbajolet-hashicorp lbajolet-hashicorp merged commit 7967e9f into main Sep 23, 2022
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix_lint_errors branch September 23, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants