Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #112

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Update docs #112

merged 2 commits into from
Aug 17, 2022

Conversation

devashish-patel
Copy link
Contributor

No description provided.

@devashish-patel devashish-patel requested a review from a team as a code owner August 16, 2022 20:19
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on other attributes that could be updated imo, but other than that :shipit: !

builder/docker/ecr_login.go Show resolved Hide resolved
@devashish-patel devashish-patel merged commit 78daf46 into main Aug 17, 2022
@devashish-patel devashish-patel deleted the dpatel/docs-update branch August 17, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devashish-patel @lbajolet-hashicorp