ebs: don't error on AMI sharing test unset #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing for the AMI sharing between accounts requires multiple extra variables to be set so we can interpolate those values in the template we run the test on. In case it is not set, the current setup makes acceptance tests fail, which can be counter-productive. To avoid this problem, we don't error when these variables are not set, but instead we skip the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing for the AMI sharing between accounts requires multiple extra variables to be set so we can interpolate those values in the template we run the test on.
In case it is not set, the current setup makes acceptance tests fail, which can be counter-productive.
To avoid this problem, we don't error when these variables are not set, but instead we skip the test.