Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: fix fast launch when using launch templates #410

Merged
merged 7 commits into from
Sep 15, 2023
Merged

builder: fix fast launch when using launch templates #410

merged 7 commits into from
Sep 15, 2023

Conversation

mtburge
Copy link
Contributor

@mtburge mtburge commented Aug 8, 2023

Fixes AWS API error when enabling EC2 Fast Launch whilst specifying a custom launch template, caused by calling the EnableFastLaunch API providing only the image id.

Also updates the test AMIs which are causing the acceptance tests to fail as the previous AMI cannot be found.

Closes #405

@mtburge mtburge requested a review from a team as a code owner August 8, 2023 15:18
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for the fix. I left one small suggestion but I will roll that in and merge.

builder/ebs/step_prepare_fast_launch_template.go Outdated Show resolved Hide resolved
@nywilken nywilken added the bug label Sep 15, 2023
@nywilken nywilken merged commit dc97d8d into hashicorp:main Sep 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packer Failed to enable fast launch: %!s(<nil>)
3 participants