command line tools for redacting keyring from snapshots #24023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
cli-keyring-redaction
branch
from
df4bb91
to
30904a5
Compare
tgross
force-pushed
the
cli-keyring-redaction
branch
from
30904a5
to
efa3c44
Compare
tgross
force-pushed
the
cli-keyring-redaction
branch
from
efa3c44
to
8b97000
Compare
|
|
shoenig
reviewed
Sep 20, 2024
In #23977 we moved the keyring into Raft, which can expose key material in Raft snapshots when using the less-secure AEAD keyring instead of KMS. This changeset adds tools for redacting this material from snapshots: * The `operator snapshot state` command gains the ability to display key metadata (only), which respects the `-filter` option. * The `operator snapshot save` command gains a `-redact` option that removes key material from the snapshot after it's downloaded. * A new `operator snapshot redact` command allows removing key material from an existing snapshot.
tgross
force-pushed
the
cli-keyring-redaction
branch
from
8b97000
to
76b18d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #23977 we moved the keyring into Raft, which can expose key material in Raft snapshots when using the less-secure AEAD keyring instead of KMS. This changeset adds tools for redacting this material from snapshots:
operator snapshot statecommand gains the ability to display key metadata (only), which respects the-filteroption.operator snapshot savecommand gains a-redactoption that removes key material from the snapshot after it's downloaded.operator snapshot redactcommand allows removing key material from an existing snapshot.Full documentation on the new keyring work coming in a separate PR