Port and AllocatedPortMapping msgpack omitempty #23980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulducat
added
theme/networking
backport/ent/1.6.x+ent
gulducat
commented
Sep 17, 2024
| "boom": &Port{ | ||
| Label: "boom_port", | ||
| }, | ||
| "boom": []string{"boom_port"}, |
There was a problem hiding this comment.
these diff tests are for task.config, which doesn't actually know what a Port is. for the docker driver, for example, ports is a list of strings (which arguably is already tested with bam above here), or a MapStrInt port_map (baz).
maybe Port here made sense at some point in the past, but doesn't seem right to me now.
to optimize log entries with empty fields, which TestPlanNormalize checks
gulducat
force-pushed
the
port_struct_omitempty
branch
from
d97e612
to
005c67b
Compare
gulducat
added
backport/ent/1.7.x+ent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to optimize log entries with empty fields, which TestPlanNormalize checks.
split out from #23956 so this can be backported.