jobspec: remove HCL1 support #23912
Merged
jobspec: remove HCL1 support #23912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
remove-hcl1-jobspec
branch
from
6c0b335
to
3cbf56b
Compare
tgross
force-pushed
the
remove-hcl1-jobspec
branch
from
3cbf56b
to
634100f
Compare
tgross
force-pushed
the
remove-hcl1-jobspec
branch
from
634100f
to
6785266
Compare
tgross
force-pushed
the
remove-hcl1-jobspec
branch
from
6785266
to
b42ebf7
Compare
schmichael
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Let's make sure to mention it in version specific upgrade docs and release notes too.
🎉 🙇 Very excited to finally remove this. A whopping 193KB off the make dev binary as a bonus.
gsa
┌─────────────────────────────────────────────────────────────────────────────┐ │ Diff between nomad-36522ec632 and nomad-remove-hcl1-jobspec │ ├─────────┬───────────────────────────────────┬──────────┬──────────┬─────────┤ │ PERCENT │ NAME │ OLD SIZE │ NEW SIZE │ DIFF │ ├─────────┼───────────────────────────────────┼──────────┼──────────┼─────────┤ │ +0.00% │ google.golang.org/api │ 653 kB │ 653 kB │ +30 B │ │ +0.00% │ github.com/fsouza/go-dockerclient │ 295 kB │ 295 kB │ +10 B │ │ -0.02% │ github.com/morikuni/aec │ 18 kB │ 18 kB │ -4 B │ │ -0.01% │ github.com/digitalocean/godo │ 260 kB │ 260 kB │ -28 B │ │ -0.02% │ -autogenerated- │ 3.3 MB │ 3.3 MB │ -520 B │ │ -0.74% │ github.com/hashicorp/nomad │ 16 MB │ 16 MB │ -122 kB │ ├─────────┼───────────────────────────────────┼──────────┼──────────┼─────────┤ │ -0.07% │ .debug_rnglists │ 1.5 kB │ 1.5 kB │ -1 B │ │ -0.03% │ .debug_loclists │ 10 kB │ 10 kB │ -3 B │ │ -0.00% │ .typelink │ 138 kB │ 138 kB │ -4 B │ │ -0.01% │ .noptrdata │ 335 kB │ 335 kB │ -32 B │ │ -0.05% │ .data │ 322 kB │ 322 kB │ -168 B │ │ -0.08% │ .symtab │ 2.8 MB │ 2.8 MB │ -2.3 kB │ │ -0.26% │ .debug_frame │ 886 kB │ 883 kB │ -2.3 kB │ │ -0.07% │ .strtab │ 7.4 MB │ 7.4 MB │ -5.2 kB │ │ -0.51% │ .debug_ranges │ 1.1 MB │ 1.1 MB │ -5.6 kB │ │ -0.20% │ .debug_line │ 3.8 MB │ 3.8 MB │ -7.5 kB │ │ -0.05% │ .rodata │ 20 MB │ 20 MB │ -11 kB │ │ -0.18% │ .debug_info │ 7.3 MB │ 7.3 MB │ -13 kB │ │ -0.38% │ .debug_loc │ 4.6 MB │ 4.5 MB │ -18 kB │ ├─────────┼───────────────────────────────────┼──────────┼──────────┼─────────┤ │ -0.18% │ nomad-36522ec632 │ 106 MB │ 106 MB │ -193 kB │ │ │ nomad-remove-hcl1-jobspec │ │ │ │ └─────────┴───────────────────────────────────┴──────────┴──────────┴─────────┘
This changeset removes support for parsing jobspecs via the long-deprecated HCLv1. Fixes: #20195 Ref: https://hashicorp.atlassian.net/browse/NET-10220
tgross
force-pushed
the
remove-hcl1-jobspec
branch
from
b42ebf7
to
6c6473e
Compare
tgross
added a commit
that referenced
this pull request
Sep 5, 2024
tgross
added a commit
that referenced
this pull request
Sep 9, 2024
HCLv1 support was removed entirely in #23912, but I missed this one test and documentation reference.
tgross
added a commit
that referenced
this pull request
Sep 9, 2024
HCLv1 support was removed entirely in #23912, but I missed this one test and documentation reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset removes support for parsing jobspecs via the long-deprecated HCLv1.
Fixes: #20195
Ref: https://hashicorp.atlassian.net/browse/NET-10220