[UI, CI] Test splitting #17626
Merged
[UI, CI] Test splitting #17626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to be used like `yarn exam:parallel -- more --options` This way a split and partition can be provided by CI without CI also needing to deal with percy details.
This will be called N times by the parent test-ui script.
This will run partitions and parallel only after linting passes.
DingoEatingFuzz
force-pushed
the
f/ui-test-splitting
branch
from
14c768f
to
64e7510
Compare
Ember Test Audit comparison
|
gulducat
approved these changes
Jun 20, 2023
This was used to integrate with Circle CI's deeper test reporting (failures, flakes, reporting). It's strictly vestigial now that we're on GHA.
DingoEatingFuzz
force-pushed
the
f/ui-test-splitting
branch
2 times, most recently
from
1dac7e6
to
464ecfe
Compare
After renovating everything, it's evident that the ember-exam sub-workflow can be inlined without any pesky duplication.
DingoEatingFuzz
force-pushed
the
f/ui-test-splitting
branch
from
464ecfe
to
d5767ac
Compare
Percy uses this to stitch parallel test runs back together into a single report.
DingoEatingFuzz
force-pushed
the
f/ui-test-splitting
branch
from
2235042
to
6c53c1e
Compare
|
Hey @philrenaud, this is looking good, but can you verify things look right in Percy before I merge? |
philrenaud
approved these changes
Jun 21, 2023
|
Backporting this PR to keep testss consistent across release branches. |
lgfa29
added
backport/1.3.x
This was referenced Jun 22, 2023
lgfa29
pushed a commit
that referenced
this pull request
Jun 22, 2023
[UI, CI] Test splitting Co-authored-by: Michael Lange <dingoeatingfuzz@gmail.com>
lgfa29
added a commit
that referenced
this pull request
Jun 22, 2023
lgfa29
pushed a commit
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI tests have already been running parallel in CI, this changes it so they aren't just parallelized on one machine (which could be leading to local state related flakiness), instead they are run across a set of GHA jobs.
Additionally, this removes the artifact uploading step, which was dutifully migrated from the previous Circle config. Mechanically the
upload-artifactaction does indeed upload the XML file just like how the Circle job worked, however, the XML file was only being generated and uploaded in service of test insights features exclusive to Circle. So this process has become strictly vestigial.