Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] A few variables-ui-related bugfixes into release/1.5.x #17328

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #17319 to be assessed for backporting due to the inclusion of the label backport/1.5.x.

The below text is copied from the body of the original PR.


  • Adds a "this variable will be accessible by all jobs" notification if saving to exactly nomad/jobs
  • moves said notification, on new variables, to the top of the form because otherwise it separated the "Add More" button and made it non-obviously connected
  • fixed a bug where a no-namespaces cluster would result in no duplicate path warnings firing
  • delete button is disabled for the only remaining KV in a variable when editing
  • fixed a bug where you would add an illegal character, delete the KV row, add a new blank one, and the illegal character warning was still present.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/ui-variable-job-info-notification/adversely-balanced-fox branch from 5410564 to 649812d Compare May 25, 2023 21:11
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit ffd7934 into release/1.5.x May 25, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/ui-variable-job-info-notification/adversely-balanced-fox branch from 9b5d91e to f5c52fe Compare May 25, 2023 21:11
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/ui-variable-job-info-notification/adversely-balanced-fox branch May 25, 2023 21:11
@vercel vercel bot temporarily deployed to Preview – nomad May 25, 2023 21:15 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui May 25, 2023 21:20 Inactive
@github-actions
Copy link

Ember Test Audit comparison

release/1.5.x f5c52fe change
passes 1489 1489 0
failures 0 0 0
flaky 0 0 0
duration 13m 39s 359ms 11m 17s 643ms -2m 21s 716ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants