Skip to content

Commit

Permalink
[ui] Ember test suite upgraded (#24020)
Browse files Browse the repository at this point in the history
* Ember test suite upgraded

* Switch up the order for the sake of testem

* Use the built-in ember test helper render for job editor rendering
  • Loading branch information
philrenaud committed Sep 20, 2024
1 parent a7f2cb8 commit e65767f
Show file tree
Hide file tree
Showing 5 changed files with 1,094 additions and 62 deletions.
8 changes: 4 additions & 4 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@ember/legacy-built-in-components": "^0.4.1",
"@ember/optional-features": "2.0.0",
"@ember/render-modifiers": "^2.0.4",
"@ember/test-helpers": "^2.6.0",
"@ember/test-helpers": "^3.0.3",
"@glimmer/component": "^1.0.4",
"@glimmer/tracking": "^1.0.4",
"@hashicorp/structure-icons": "^1.3.0",
Expand All @@ -64,7 +64,7 @@
"d3-time-format": "^4.0.0",
"d3-transition": "^3.0.1",
"duration-js": "^4.0.0",
"ember-a11y-testing": "^4.0.0",
"ember-a11y-testing": "^7.0.0",
"ember-auto-import": "^2.4.0",
"ember-can": "^4.1.0",
"ember-classic-decorator": "^3.0.0",
Expand Down Expand Up @@ -104,7 +104,7 @@
"ember-overridable-computed": "^1.0.0",
"ember-page-title": "^7.0.0",
"ember-power-select": "^7.2.0",
"ember-qunit": "^5.1.5",
"ember-qunit": "^8.1.0",
"ember-render-helpers": "^0.2.0",
"ember-resolver": "^8.0.3",
"ember-responsive": "^4.0.2",
Expand Down Expand Up @@ -140,7 +140,7 @@
"qunit": "^2.17.2",
"qunit-dom": "^2.0.0",
"sass": "^1.17.3",
"testem": "^3.0.3",
"testem": "^3.15.2",
"testem-multi-reporter": "^1.2.0",
"text-encoder-lite": "^2.0.0",
"webpack": "^5.86.0",
Expand Down
1 change: 1 addition & 0 deletions ui/testem.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const config = {
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
parallel: -1,
framework: 'qunit',
browser_args: {
// New format in testem/master, but not in a release yet
// Chrome: {
Expand Down
2 changes: 1 addition & 1 deletion ui/tests/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@
</div>
</div>

<script src="/testem.js" integrity="" data-embroider-ignore></script>
<script src="{{ rootURL }}assets/vendor.js"></script>
<script src="{{ rootURL }}assets/test-support.js"></script>
<script src="{{ rootURL }}assets/nomad-ui.js"></script>
<script src="/testem.js" integrity="" data-embroider-ignore></script>
<script src="{{ rootURL }}assets/tests.js"></script>

{{content-for "body-footer"}}
Expand Down
2 changes: 1 addition & 1 deletion ui/tests/integration/components/job-editor-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ module('Integration | Component | job-editor', function (hooks) {
handleSaveAsTemplate: sinon.spy(),
context: 'new',
});
await component.render(commonTemplate);
await render(commonTemplate);
};

const planJob = async (spec) => {
Expand Down
Loading

0 comments on commit e65767f

Please sign in to comment.