-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppSideNav
- component main branch (HDS-3800)
#2384
Open
KristinLBradley
wants to merge
54
commits into
main
Choose a base branch
from
hds-3800-app-sidenav-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,723
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…sabling for entire template and instead add only where needed
KristinLBradley
force-pushed
the
hds-3800-app-sidenav-component
branch
from
September 26, 2024 18:39
aae4586
to
e796a0d
Compare
KristinLBradley
changed the title
Sep 26, 2024
AppSideNav
- component (HDS-3800)AppSideNav
- component main branch (HDS-3800)
KristinLBradley
changed the title
Sep 26, 2024
AppSideNav
- component main branch (HDS-3800)AppSideNav
- component **main branch** (HDS-3800)
KristinLBradley
changed the title
Sep 26, 2024
AppSideNav
- component **main branch** (HDS-3800)AppSideNav
- component __main branch__ (HDS-3800)
KristinLBradley
changed the title
Sep 26, 2024
AppSideNav
- component __main branch__ (HDS-3800)AppSideNav
- component main branch (HDS-3800)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS:
SideNav
component deprecation in separate branch ready for review🔷 NOTE: Branch will NOT be merged immediately after approval. It will be kept open & branched off of for follow on tasks. This will make it easier to review changes which different from original SideNav code that this branch is based on.
📌 Summary
If merged, this PR will add the
AppSideNav
component to HDS.Previews:
Related branches:
AddSideNav
Documentation:AppSideNav
- web docs sub-branch (HDS-3807) #2410SideNav
Deprecation:SideNav
- Deprecate component sub-branch (HDS-3848) #2425🛠️ Detailed description
The majority of code was duplicated from the
SideNav
and then updated to implement the newAppSideNav
component.Major differences of note:
AppSideNav
has an updated visual design using lighter colors than theSideNav
:header
named block was simplified to act as a basic yielded container:logo
&:actions
child named blocks were removedHeader
andHeader::HomeLink
child components were removed.(KB: undid this change):header
and:footer
named blocks were removedAppHeader
which already includes thisAppSideNav Follow-ons (recommended):
AppSideNav
- component main branch (HDS-3800) #2384 (comment)AppSideNav
- component main branch (HDS-3800) #2384 (comment)AppSideNav
- component main branch (HDS-3800) #2384 (comment)AppSideNav
- component main branch (HDS-3800) #2384 (comment)AppSideNav
- component main branch (HDS-3800) #2384 (comment)AppSideNav
- component main branch (HDS-3800) #2384 (comment)🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.