Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppSideNav - component main branch (HDS-3800) #2384

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Sep 3, 2024

STATUS:

🔷 NOTE: Branch will NOT be merged immediately after approval. It will be kept open & branched off of for follow on tasks. This will make it easier to review changes which different from original SideNav code that this branch is based on.


📌 Summary

If merged, this PR will add the AppSideNav component to HDS.

Previews:

Related branches:

🛠️ Detailed description

The majority of code was duplicated from the SideNav and then updated to implement the new AppSideNav component.

Major differences of note:

  • The AppSideNav has an updated visual design using lighter colors than the SideNav
    • Dark theme styles are no longer added to nested Button & Dropdown components
  • The AppSideNav :header named block was simplified to act as a basic yielded container
    • The :logo & :actions child named blocks were removed
    • The Header and Header::HomeLink child components were removed.
    • :header and :footer named blocks were removed (KB: undid this change)
  • The Navigator Narrator (skip link) was removed as the AppSideNav is meant to always be paired with the AppHeader which already includes this

AppSideNav Follow-ons (recommended):

🔗 External links


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Sep 26, 2024 6:43pm
hds-website ✅ Ready (Inspect) Visit Preview Sep 26, 2024 6:43pm

@KristinLBradley KristinLBradley requested a review from a team September 26, 2024 20:19
@KristinLBradley KristinLBradley changed the title AppSideNav - component (HDS-3800) AppSideNav - component main branch (HDS-3800) Sep 26, 2024
@KristinLBradley KristinLBradley changed the title AppSideNav - component main branch (HDS-3800) AppSideNav - component **main branch** (HDS-3800) Sep 26, 2024
@KristinLBradley KristinLBradley changed the title AppSideNav - component **main branch** (HDS-3800) AppSideNav - component __main branch__ (HDS-3800) Sep 26, 2024
@KristinLBradley KristinLBradley changed the title AppSideNav - component __main branch__ (HDS-3800) AppSideNav - component main branch (HDS-3800) Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants