Merge pull request #2453 from hashicorp/hds-3889/fix-dialog-footer-close

`DialogPrimitive`: add a guard so the yielded `close` function is always defined

.changeset/tricky-forks-lay.md

@@ -0,0 +1,5 @@
+---
+"@hashicorp/design-system-components": patch
+---
+
+`DialogPrimitive`: added a guard so the yielded close function is always defined'

packages/components/src/components/hds/dialog-primitive/footer.hbs

@@ -3,5 +3,5 @@
   SPDX-License-Identifier: MPL-2.0
 }}
 <div class="hds-dialog-primitive__footer {{@contextualClass}}" ...attributes>
-  {{yield (hash close=@onDismiss)}}
+  {{yield (hash close=this.onDismiss)}}
 </div>

packages/components/src/components/hds/dialog-primitive/footer.ts

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: MPL-2.0
  */
 
-import templateOnlyComponent from '@ember/component/template-only';
+import Component from '@glimmer/component';
 
 export interface HdsDialogPrimitiveFooterSignature {
   Args: {
@@ -15,14 +15,26 @@ export interface HdsDialogPrimitiveFooterSignature {
     default: [
       {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        close?: (event: MouseEvent, ...args: any[]) => void;
+        close: (event: MouseEvent, ...args: any[]) => void;
       },
     ];
   };
   Element: HTMLDivElement;
 }
 
-const HdsDialogPrimitiveFooter =
-  templateOnlyComponent<HdsDialogPrimitiveFooterSignature>();
+const NOOP = (): void => {};
 
-export default HdsDialogPrimitiveFooter;
+export default class HdsDialogPrimitiveFooter extends Component<HdsDialogPrimitiveFooterSignature> {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  get onDismiss(): (event: MouseEvent, ...args: any[]) => void {
+    const { onDismiss } = this.args;
+
+    // notice: this is to make sure the function is always defined when consumers add `{{on 'click' F.close}}` to a button in the DialogFooter.
+    // in reality it's always used inside the main components as a yielded component, so the onDismiss handler is always defined
+    if (typeof onDismiss === 'function') {
+      return onDismiss;
+    } else {
+      return NOOP;
+    }
+  }
+}