Short-list just the Harfbuzz sources we need #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GNU Make, Cmake, Python scripts, and other random stuff in Harfbuzz's source directory are not relevant to the cython build which only uses the amalgam file (harfbuzz.cc) and compiles it using a c++ compiler directly. This includes the other sources and header files, but doesn't need any of the build machinery.
anthrotype
reviewed
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GNU Make, Cmake, Python scripts, and other random stuff in
Harfbuzz's source directory are not relevant to the cython build which
only uses the amalgam file (harfbuzz.cc) and compiles it using a c++
compiler directly. This includes the other sources and header files, but
doesn't need any of the build machinery.
See discussion on #62.
No need to release for this as 0.13.2 isn't broken. This is just a tidy set of sources for next time.