Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing a subshaper array to shape #55

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Allow passing a subshaper array to shape #55

merged 4 commits into from
Jul 22, 2020

Conversation

simoncozens
Copy link
Collaborator

No description provided.

justvanrossum
justvanrossum requested changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be good (doesn't need to test anything fancy, just that your hb_shape_full block gets executed at all).

Please keep two blank lines before and after function definitions.

anthrotype
anthrotype approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@simoncozens simoncozens merged commit b744d22 into harfbuzz:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justvanrossum justvanrossum justvanrossum approved these changes

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simoncozens @justvanrossum @anthrotype