Make hb-ot-* bindings more Pythonic #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works with Cython 3.0
khaledhosny
force-pushed
the
pythonic-api
branch
from
d062b85
to
f86cc76
Compare
Instead of module-level ot_math_* functions, make them methods of Face or Font classes, as appropriate.
Instead of module-level ot_metric_* functions, make them methods of Face or Font classes, as appropriate.
khaledhosny
force-pushed
the
pythonic-api
branch
from
f86cc76
to
1b288e7
Compare
Instead of module-level ot_color_* functions, make them methods of Face or Font classes, as appropriate. Also simplify getting color palettes.
Instead of module-level ot_layout_* functions, make them methods of Face or Font classes, as appropriate. A couple of functions that don’t take Face or Font as input were left unchanged.
khaledhosny
force-pushed
the
pythonic-api
branch
from
aab15b3
to
9b17dca
Compare
|
LGTM. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were added as top level functions, but that feels odd on Python when we already have
FaceandFontclasses. This deprecate the top level functions and adds corresponding methods toFaceorFontclasses as appropriate.