add a sample.py script #2

anthrotype · 2018-03-24T14:02:18Z

I was just playing with the api and tried to rewrite the sample script from harfbuzz upstream repo using uharfbuzz:
https://github.com/harfbuzz/harfbuzz/blob/master/src/sample.py

just scrap it if you think we don't need it here

…age_func

the python callback for the buffer message func only takes a str (message) for now... Not sure how or whether I should pass buffer and font (or even user_data) on to it. uuzz/_harfbuzz.pyx

anthrotype · 2018-03-24T14:06:02Z

src/uharfbuzz/_harfbuzz.pyx

    @classmethod
-    def create(self, blob: Blob, index: int):
+    def create(cls, fontdata: bytes, index: int):


since it's a python function, here we could probably accept not only just bytes, but a union of bytes/bytearray/array.array or anything that exposes the buffer interface really.

I meant not only

so you're looking for memoryview? also can you keep the name blob (and below hb_blob), thus far I keep the same signature names as harfbuzz. (and bytes is a binary "blob" so.. we can revisit later if needed)

anthrotype · 2018-04-12T14:18:43Z

yo @adrientetar

adrientetar

Thanks, I thought of putting an example such as this. Good to have!

adrientetar · 2018-04-12T18:05:15Z

examples/sample.py

@@ -0,0 +1,45 @@
+#!/usr/bin/python3
+
+from __future__ import print_function


we don't need this?

adrientetar · 2018-04-12T18:06:40Z

examples/sample.py

+import sys
+
+
+with open(sys.argv[1], 'rb') as fp:


nit: fp → fontfile?

adrientetar · 2018-04-12T18:10:20Z

examples/sample.py

+face = hb.Face.create(fontdata, 0)
+font = hb.Font.create(face)
+upem = face.upem
+del face


nit: font keeps a reference to face, so "del face" isn't doing much here. Is it here to somehow highlight that face isn't used after that point?

not really, was just a blind copy from harfbuzz own example script

adrientetar · 2018-04-12T18:10:51Z

examples/sample.py

+    x_advance = pos.x_advance
+    x_offset = pos.x_offset
+    y_offset = pos.y_offset
+    print("gid%d=%d@%d,%d+%d" % (gid, cluster, x_advance, x_offset, y_offset))


nit: could use an f-string ;)

adrientetar · 2018-04-12T18:11:59Z

src/uharfbuzz/_harfbuzz.pyx

+        # XXX I'm passing the python callback as user_data and recovering it
+        # from the C-API func below. Is there a better way?
+        # Also, the callback is only taking a message argument, no buffer,
+        # nor font or its own user_data. Not sure whether/how to pass them on


We could probably look into this, but do we at all need implementing "message func" in the first place?

The nice thing about the other stuff I put thus far is I use it so I know what things need to be passed to python or not..

I don't know if we need to implement it. I was just trying to port the simple debugger that is exemplified in the harfbuzz's original sample.py, but using uharfbuzz.

maybe we can leave it out for now, I've never needed to use it myself

@adrientetar I removed it from the example. Shall I remove the set_message_func method altogether from the pyx source file as well?

yes, and pxd too

adrientetar · 2018-04-12T18:14:28Z

src/uharfbuzz/_harfbuzz.pyx

    @classmethod
-    def create(self, blob: Blob, index: int):
+    def create(cls, fontdata: bytes, index: int):


so you're looking for memoryview? also can you keep the name blob (and below hb_blob), thus far I keep the same signature names as harfbuzz. (and bytes is a binary "blob" so.. we can revisit later if needed)

adrientetar · 2018-04-12T18:15:09Z

src/uharfbuzz/_harfbuzz.pyx

@@ -451,3 +468,7 @@ def ot_layout_table_get_script_tags(face: Face, tag: str) -> List[str]:
        packed = cstr
        tags.append(packed.decode())
    return tags
+
+
+cpdef void ot_font_set_funcs(Font font):


Why cpdef here? I used def for all module level functions.

I don't mind cpdef (is it more efficient?) but we should use it consistently in the file then

it's only more efficient in so far as you also need to call a cpdef function from within cython (in which case it uses its faster cdef version). But if we only call this from python, then def is ok.

adrientetar · 2018-04-12T18:16:02Z

src/uharfbuzz/charfbuzz.pxd

@@ -197,3 +203,6 @@ cdef extern from "hb-ot.h":
        unsigned int start_offset,
        unsigned int* script_count,  # in/out
        hb_tag_t* script_tags)  # out
+
+    # hb-ot-font.h
+    void hb_ot_font_set_funcs(hb_font_t *font)


nit: so far I put the stars before the space

I copy-pasted it from the harfbuzz headers, which put the stars after the space, but I don't mind.

adrientetar · 2018-04-12T18:16:47Z

examples/sample.py

@@ -0,0 +1,45 @@
+#!/usr/bin/python3


I think we could simply put this example in the readme, it's the first file ppl look at so more convenient.

PyPI now supports Github Flavoured Markdown, enough with reStructuredText.

Adrien likes it that way

adrientetar · 2018-04-19T15:54:04Z

setup.py

@@ -1,12 +1,22 @@
 #!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 from skbuild import setup
+import os
+from io import open


nit: can you sort the imports

adrientetar · 2018-04-19T15:54:20Z

src/uharfbuzz/_harfbuzz.pyx

+        # XXX I'm passing the python callback as user_data and recovering it
+        # from the C-API func below. Is there a better way?
+        # Also, the callback is only taking a message argument, no buffer,
+        # nor font or its own user_data. Not sure whether/how to pass them on


yes, and pxd too

adrientetar · 2018-04-19T15:55:03Z

src/uharfbuzz/_harfbuzz.pyx

        cdef Face inst = cls()
-        inst._hb_face = hb_face_create(blob, index)
+        cdef hb_blob_t* cblob = hb_blob_create(


nit: name it hb_blob

either we do it properly or we don't, says Adrien

anthrotype added 3 commits March 24, 2018 13:55

[charfbuzz] add declarations for ot_font_set_funcs and hb_buffer_mess…

28215a5

…age_func

[_harfbuzz] expose Face.create (from bytes) and Buffer.set_message_func

c3e5235

the python callback for the buffer message func only takes a str (message) for now... Not sure how or whether I should pass buffer and font (or even user_data) on to it. uuzz/_harfbuzz.pyx

add examples/sample.py (borrowed from harfbuzz/src/sample.py)

55b6d2b

anthrotype commented Mar 24, 2018

View reviewed changes

adrientetar reviewed Apr 12, 2018

View reviewed changes

anthrotype added 9 commits April 19, 2018 15:59

Face.create: keep arg name 'blob', default index=0

953b5a6

_harfbuzz.pyx: use def instead of cpdef for ot_font_set_funcs

1288bb6

sample.py: f-strings + minor changes

df9301f

Added sample.py to README.md, removed README.rst

f7c86cd

PyPI now supports Github Flavoured Markdown, enough with reStructuredText.

setup.py: use markdown README.md for long_description

e782ab0

README.md: cosmetics

56a9891

removed examples/sample.py: code is now in README.md

9fee103

README.md: remove call to set_message_func

ec6accf

put the deref operator next to the type, before the space

cfd0e48

Adrien likes it that way

adrientetar reviewed Apr 19, 2018

View reviewed changes

anthrotype and others added 4 commits April 19, 2018 17:01

remove incomplete set_message_func implementation

c70f467

either we do it properly or we don't, says Adrien

fix typos

b7dd16e

charfbuzz.pxd: remove unused declarations for message_func api

a726ce0

Cosmetics

ef522ed

adrientetar merged commit 950a051 into master Apr 19, 2018

adrientetar deleted the sample-py branch April 19, 2018 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a sample.py script #2

add a sample.py script #2

anthrotype commented Mar 24, 2018

anthrotype Mar 24, 2018 •

edited

Loading

anthrotype Mar 24, 2018

adrientetar Apr 12, 2018

anthrotype commented Apr 12, 2018

adrientetar left a comment

adrientetar Apr 12, 2018

adrientetar Apr 12, 2018

adrientetar Apr 12, 2018

anthrotype Apr 19, 2018

adrientetar Apr 12, 2018

adrientetar Apr 12, 2018

anthrotype Apr 19, 2018

adrientetar Apr 19, 2018

anthrotype Apr 19, 2018

anthrotype Apr 19, 2018 •

edited

Loading

adrientetar Apr 19, 2018

adrientetar Apr 12, 2018

adrientetar Apr 12, 2018

anthrotype Apr 19, 2018

adrientetar Apr 12, 2018

anthrotype Apr 19, 2018

adrientetar Apr 12, 2018

anthrotype Apr 19, 2018

adrientetar Apr 19, 2018

adrientetar Apr 19, 2018

adrientetar Apr 19, 2018

		@@ -0,0 +1,45 @@
		#!/usr/bin/python3

		from __future__ import print_function

add a sample.py script #2

add a sample.py script #2

Conversation

anthrotype commented Mar 24, 2018

anthrotype Mar 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anthrotype commented Apr 12, 2018

adrientetar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anthrotype Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anthrotype Mar 24, 2018 •

edited

Loading

anthrotype Apr 19, 2018 •

edited

Loading