Fix json overrides #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-lau
force-pushed
the
fix-json-overrides
branch
from
9b38630
to
18cedaa
Compare
msimerson
reviewed
May 12, 2024
msimerson
approved these changes
May 12, 2024
msimerson
added a commit
that referenced
this pull request
May 12, 2024
- doc(README): fix hjson link (#78)
Merged
msimerson
added a commit
that referenced
this pull request
May 12, 2024
- doc(README): fix hjson link (#78)
|
thanks @louis-lau ! |
msimerson
added a commit
that referenced
this pull request
May 12, 2024
|
Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some vague references to a single file config option. After figuring out how to use, it didn't really seem to work. So I dug in and fixed it!
smtp.jsonseems to have been accidentally removed in this commit 8 years ago from what I can tell:haraka/Haraka@fefae7c
this._overrideswas checked, but there wasn't any code setting values there. Must have been accidentally removed at some point as well.Fixes #69
Fixes #68
Fixes #66