Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configfile: convert to es6 class #57

Merged
merged 6 commits into from
Mar 23, 2020
Merged

configfile: convert to es6 class #57

merged 6 commits into from
Mar 23, 2020

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Nov 25, 2019

  • configfile: convert to es6 class
  • configfile.read_dir: promisify
  • configfile: use simpler es6 for..in and for..of
  • configfile.watch_dir: move declared function to callback (for this scoping)

@msimerson
Copy link
Member Author

msimerson commented Nov 25, 2019

Note for reviewers, the first commit (convert to es6 class) has a ton of noise and no real functional changes. It's much easier to review the following 3 commits individually, with the ignore whitespace option enabled.

@msimerson msimerson closed this Nov 25, 2019
@msimerson msimerson reopened this Nov 25, 2019
@msimerson msimerson merged commit 3996f25 into master Mar 23, 2020
@msimerson msimerson deleted the class-configfile branch March 23, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant