Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hjson support > Update README.md #38

Merged
merged 5 commits into from Oct 5, 2017
Merged

Add Hjson support > Update README.md #38

merged 5 commits into from Oct 5, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 30, 2017

fixes #37

@codecov
Copy link

codecov bot commented Sep 30, 2017

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files           8        8           
  Lines         428      428           
  Branches      124      124           
=======================================
  Hits          349      349           
  Misses         79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c953aa...8b873c5. Read the comment docs.

README.md Outdated
Hjson is a syntax extension to JSON. It is intended to be used like a user interface for humans, to read and edit before passing the JSON data to the machine. That means you can use it to parse JSON files but it is not intended as a replacement.

You can check Hjson's homepage at https://hjson.org to get familiar with it and you can try out it's syntax at https://hjson.org/try.html.

Copy link
Member

@msimerson msimerson Sep 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you actually had links in this paragraph. Such as:

You can see the Hjson homepage and try out its syntax.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I was unsure about this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These .md files support any features of GitHub Flavored Markdown. You're encouraged to use them. :-)

README.md Outdated

Hjson is a syntax extension to JSON. It is intended to be used like a user interface for humans, to read and edit before passing the JSON data to the machine. That means you can use it to parse JSON files but it is not intended as a replacement.

You can check [Hjson's homepage](https://hjson.org) to get familiar with it and you can [try out it's syntax](https://hjson.org/try.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

english nit: it's -> its

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@msimerson msimerson Sep 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I too know the difference, but I still make that error ALL THE TIME. That's why I'm always watching for it. ;)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, did not know that, thank you. But it applies only to it right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I remember is the "it is or it has" rule. If you can't stick "it is" in the place of it's, then the correct spelling is its. It's a stupid rule because English is so irregular.

README.md Outdated

Example syntax

```
Copy link
Member

@msimerson msimerson Sep 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GFM supports syntax highlighting. It doesn't appear to support HJSON but JS looks to be an improvement:

{
     # specify rate in requests/second (because comments are helpful!)
     rate: 1000
 
     // prefer c-style comments?
     /* feeling old fashioned? */
 
     # did you notice that rate does not need quotes?
     hey: look ma, no quotes for strings either!
 
     # best of all
     notice: []
     anything: ?
 
     # yes, commas are optional!
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that but if you use whole example it is messed up due to an apostrophe.

{
    # specify rate in requests/second (because comments are helpful!)
    rate: 1000

    // prefer c-style comments?
    /* feeling old fashioned? */

    # did you notice that rate doesn't need quotes?
    hey: look ma, no quotes for strings either!

    # best of all
    notice: []
    anything: ?

    # yes, commas are optional!
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok I see what you did there. I am going to change it.

@msimerson msimerson merged commit 220c41c into haraka:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hjson support > Update README.md
2 participants