Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-no-var #29

Merged
merged 2 commits into from
Sep 21, 2017
Merged

eslint-no-var #29

merged 2 commits into from
Sep 21, 2017

Conversation

msimerson
Copy link
Member

  • extend lint tests to readers/*.js
  • add a few more tests

@codecov
Copy link

codecov bot commented Sep 21, 2017

Codecov Report

Merging #29 into master will increase coverage by 0.19%.
The diff coverage is 92.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   80.53%   80.73%   +0.19%     
==========================================
  Files           7        7              
  Lines         411      410       -1     
  Branches      118      118              
==========================================
  Hits          331      331              
+ Misses         80       79       -1
Impacted Files Coverage Δ
readers/json.js 100% <100%> (ø) ⬆️
readers/yaml.js 100% <100%> (ø) ⬆️
readers/binary.js 100% <100%> (ø) ⬆️
readers/flat.js 80% <75%> (-0.49%) ⬇️
readers/ini.js 97.22% <95.83%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fced0c4...2f766f0. Read the comment docs.

@msimerson msimerson merged commit ce7243a into master Sep 21, 2017
@msimerson msimerson deleted the eslint-no-var branch September 21, 2017 20:35
@msimerson msimerson changed the title WIP: eslint-no-var eslint-no-var Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant