process.env.HARAKA_TEST_DIR

[msimerson]

• add process.env.HARAKA_TEST_DIR support (synced from haraka/Haraka/config.js)
• lint updates for tests
• add __dirname/../../config to config_dir_candidates (for haraka/Haraka/*.js)

[codecov]

Codecov Report

Merging #27 into master will decrease coverage by 0.19%.
The diff coverage is 57.14%.

@@            Coverage Diff            @@
##           master      #27     +/-   ##
=========================================
- Coverage   79.46%   79.26%   -0.2%     
=========================================
  Files           7        7             
  Lines         409      410      +1     
  Branches      114      115      +1     
=========================================
  Hits          325      325             
- Misses         84       85      +1

Impacted Files	Coverage Δ
config.js	89.04% <50%> (-2.51%)	⬇️
configfile.js	67.48% <66.66%> (+0.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320406e...69c309c. Read the comment docs.

[msimerson]

The only reason I'm requesting a review is due to this change. The rest of the changes are all pedestrian.

Thus far, the only time haraka-config/configfile.js was run is when a npm packaged plugin loaded it via it's test suite. This change permits haraka/Haraka/* scripts to also find the correct path to /config/ when they are running outside Haraka (primarily: their test suites). I can't think of any cases where this would fail but another set of eyes would be appreciated.

[smfreegard]

LGTM