Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config.getDir, loads all files in a directory #18

Merged
merged 5 commits into from
Mar 7, 2017

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Mar 5, 2017

this is in preparation for haraka/Haraka#1828

  • api for getDir is a node callback
  • unlike get, getDir is async and returns nothing. The results are in the callback.
  • internally, getDir is implemented entirely with promises
  • dir watching

@codecov-io
Copy link

codecov-io commented Mar 5, 2017

Codecov Report

Merging #18 into master will increase coverage by 2.27%.
The diff coverage is 97.77%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   77.38%   79.65%   +2.27%     
==========================================
  Files           7        7              
  Lines         367      408      +41     
  Branches      106      114       +8     
==========================================
+ Hits          284      325      +41     
  Misses         83       83
Impacted Files Coverage Δ
configfile.js 67.48% <100%> (+6.54%)
readers/binary.js 100% <100%> (ø)
config.js 91.54% <80%> (+0.24%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888f0dd...8beb293. Read the comment docs.

@msimerson msimerson merged commit b4f65b0 into master Mar 7, 2017
@msimerson msimerson deleted the 1828-config-getDir branch March 7, 2017 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants