Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(running Node v12.18.4 and Haraka master branch)
My autobuild started to fail without any code change in special case when email is forced through smarthost and that smarthost should deliver to target location. Haraka here acts as smarthost and only in that case Haraka emits twice EHLOs and then communication will start to loose continuity like that:
I suspect that some node internals has changed. Anyways changing "on" to "once" at secure listener fix this.