Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hmail.js #2838

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Update hmail.js #2838

merged 2 commits into from
Sep 21, 2020

Conversation

analogic
Copy link
Collaborator

@analogic analogic commented Sep 21, 2020

(running Node v12.18.4 and Haraka master branch)

My autobuild started to fail without any code change in special case when email is forced through smarthost and that smarthost should deliver to target location. Haraka here acts as smarthost and only in that case Haraka emits twice EHLOs and then communication will start to loose continuity like that:

2020-09-21T12:23:16.715Z [1] [PROTOCOL] [outbound] C: STARTTLS
2020-09-21T12:23:16.716Z [1] [PROTOCOL] [outbound] S: 220 Go ahead.\r\n
2020-09-21T12:23:16.728Z [1] [INFO] [outbound] secured verified=false cipher=ECDHE-RSA-AES128-GCM-SHA256 version=TLSv1.2 error=CERT_HAS_EXPIRED cn=server organization=QSMTPD issuer=QSMTPD expires="Sep 17 08:11:42 2020 GMT" fingerprint=D7:7D:DB:97:67:B0:C7:76:0E:A3:AA:0E:51:5B:9D:BA:F4:68:4B:63

2020-09-21T12:23:16.728Z [1] [PROTOCOL] [outbound] C: EHLO mail.server-2.com
2020-09-21T12:23:16.728Z [1] [PROTOCOL] [outbound] C: EHLO mail.server-2.com
2020-09-21T12:23:16.746Z [1] [PROTOCOL] [outbound] S: 250-mail.server-3.com Hello pro.server-2.com.pro_mynet [172.22.0.20], Server is at your service\r\n
2020-09-21T12:23:16.746Z [1] [PROTOCOL] [outbound] S: 250-PIPELINING\r\n
2020-09-21T12:23:16.746Z [1] [PROTOCOL] [outbound] S: 250-8BITMIME\r\n
2020-09-21T12:23:16.746Z [1] [PROTOCOL] [outbound] S: 250-SMTPUTF8\r\n
2020-09-21T12:23:16.746Z [1] [PROTOCOL] [outbound] S: 250-SIZE 26214400\r\n
2020-09-21T12:23:16.746Z [1] [PROTOCOL] [outbound] S: 250 AUTH PLAIN LOGIN\r\n

2020-09-21T12:23:16.746Z [1] [PROTOCOL] [outbound] C: MAIL FROM:<sourcesmtp2route621172996@server-1.com>
2020-09-21T12:23:16.770Z [1] [PROTOCOL] [outbound] S: 250-mail.server-3.com Hello pro.server-2.com.pro_mynet [172.22.0.20], Server is at your service\r\n
2020-09-21T12:23:16.771Z [1] [PROTOCOL] [outbound] S: 250-PIPELINING\r\n
2020-09-21T12:23:16.771Z [1] [PROTOCOL] [outbound] S: 250-8BITMIME\r\n
2020-09-21T12:23:16.771Z [1] [PROTOCOL] [outbound] S: 250-SMTPUTF8\r\n
2020-09-21T12:23:16.771Z [1] [PROTOCOL] [outbound] S: 250-SIZE 26214400\r\n
2020-09-21T12:23:16.771Z [1] [PROTOCOL] [outbound] S: 250 AUTH PLAIN LOGIN\r\n

2020-09-21T12:23:16.771Z [1] [PROTOCOL] [outbound] C: RCPT TO:<destinationsmtp2route621172996@server-3.com>
2020-09-21T12:23:16.797Z [1] [PROTOCOL] [outbound] S: 250 sender <sourcesmtp2route621172996@server-1.com> OK\r\n

2020-09-21T12:23:16.797Z [1] [PROTOCOL] [outbound] C: DATA
2020-09-21T12:23:16.802Z [1] [PROTOCOL] [outbound] S: 250 recipient <destinationsmtp2route621172996@server-3.com> OK\r\n

I suspect that some node internals has changed. Anyways changing "on" to "once" at secure listener fix this.

Fixing some strage obscure case
@msimerson msimerson merged commit a31c16d into master Sep 21, 2020
@msimerson msimerson deleted the analogic-patch-3 branch September 21, 2020 20:44
@msimerson
Copy link
Member

msimerson commented Sep 29, 2020

I wonder if this is related to #2828 and #2743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants