Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls socket peer info #2648

Merged
merged 4 commits into from
May 23, 2019
Merged

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented May 21, 2019

Fixes #2634

Changes proposed in this pull request:

  • conn: remove TLS version from header
  • conn: suppress verify message when =FAIL (it is confusing)
  • ws: clean up a few log messages

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #2648 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2648   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files          29       29           
  Lines        6387     6387           
  Branches     1587     1587           
=======================================
  Hits         3815     3815           
  Misses       2572     2572
Impacted Files Coverage Δ
outbound/hmail.js 55% <100%> (ø) ⬆️
logger.js 89.2% <100%> (ø) ⬆️
connection.js 50.99% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d06fed...a220618. Read the comment docs.

@msimerson msimerson requested a review from a team May 23, 2019 00:20
Copy link
Member

@KingNoosh KingNoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KingNoosh KingNoosh merged commit 2171d20 into haraka:master May 23, 2019
@msimerson msimerson deleted the 2634-tls-socket-peer-info branch May 23, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TLSSocket peer certificate verification info from sslheader
2 participants