-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FUSE-T support on macOS #453
Conversation
Signed-off-by: Alex Fishman <alex@fuse-t.org>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fuse-t is quite interesting! I have added a few comment on the code.
However, to get this merged, you will have to send the changes via gerrithub ( see
https://github.com/hanwen/go-fuse/blob/master/CONTRIBUTING )
BTW, this could be tested on Github Actions, right? |
I don't have experience with Github Actions, but testing should be easy. fuse-t can be installed with homebrew before running tests and that's the only requirement |
Signed-off-by: Alex Fishman <alex@fuse-t.org>
Signed-off-by: Alex Fishman <alex@fuse-t.org>
Most of the comments are addressed. Please take a look at the new commits |
Signed-off-by: Alex Fishman <alex@fuse-t.org>
Signed-off-by: Alex Fishman <alex@fuse-t.org>
thanks for your contribution! As discussed above, it would be swell to get a gerrithub review for this. As an aside, I've been mulling implementing NFS natively directly in go-fuse, but I haven't found a good description of the NFS protocol yet. I guess you'd rather see people pay you for fuse-t, but maybe you can comment on how much complexity the NFS <-> FUSE bridge involves? |
When do you plan add this changes to master branch ? |
I do not have concrete plans; my comments in the code review have gone unanswered. |
I don't have time for this. But @libor13 can use the forked repo |
Please add support for -o location option added in fuse-t 1.0.22 |
That's really a pity! :-( Just FYI: I tried to sign up on Gerrit (I had already signed the Google's CLA, which is also trivial to do), and, after five minutes, I had everything set up for my own repositories. That's all it takes, it won't eat much from your precious time... |
@macos-fuse-t do you have plan to merge current changes from hanwen:master to your branch ? |
When I try to mount virtual drive from gocryptfs using last source from macos-fuse-t/go-fuse I got this error:
|
Any update @macos-fuse-t @hanwen? That would definitely be a good addition to integrate fuse-t since the opening of this PR a year ago. |
no activity. Closing. |
This pull request implements support for FUSE-T, which eliminates the need to install kernel extensions on macOS.
https://github.com/macos-fuse-t/fuse-t