Fix bug where validation errors could overwrite previous validation errors #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation errors were stored by object ID, which made no sense. It wasn't necessary, but provided the possibility of a validation error overwriting a previous one that applied to the same object. On top of that, this change is a simplification, so a win all around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation errors were stored in a map, by object ID, which means that only one validation error could be stored per object. This made no sense, and this pull request fixes it. It's also a simplification, so a win all around.
This seems to be a really old bug, but I don't think it had much impact. It could not lead to the presence of validation errors being missed. It could just prevent the user from having a complete picture of what is wrong, if there already are validation errors.