Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README - add handlebars-rust in the Wild #2038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Binlogo
Copy link

@Binlogo Binlogo commented Aug 20, 2024

Before creating a pull-request, please check https://github.com/handlebars-lang/handlebars.js/blob/master/CONTRIBUTING.md first.

Generally we like to see pull requests that

  • Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • Have good commit messages
  • Have tests
  • Have the typings (types/index.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
  • Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

@jaylinski
Copy link
Member

jaylinski commented Aug 21, 2024

As far as I know, we only document things in this section that use the handlebars-js library from this repo.

Other languages are documented here: https://handlebarsjs.com/installation/#other-programming-languages

But I think we should add a "Other programming languages"-section in the README too.

I'll keep this PR open and will think about it.

@Binlogo
Copy link
Author

Binlogo commented Aug 22, 2024

Thank you for your information. Documenting other programming languages can help users of different backgrounds get started quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants