add database tooling #169
Merged
add database tooling #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #169 +/- ##
==========================================
+ Coverage 75.41% 77.08% +1.67%
==========================================
Files 19 20 +1
Lines 480 515 +35
==========================================
+ Hits 362 397 +35
Misses 118 118
Continue to review full report at Codecov.
|
clarkerican
requested changes
Jan 22, 2018
| * Facilitates prompting the user for their username and password | ||
| * @returns credentials the username and password of the user | ||
| */ | ||
| export async function signInToSequelize() { |
There was a problem hiding this comment.
change the name of this function to signIntoMysql in case other dbs in the future need mysql credentials
There was a problem hiding this comment.
Not going to change to keep since this just calls a common method anyways and we might want to add new tools later, which would require a separate function.
src/services/sequelize-service.js
Outdated
| file.writeFile(`${projectName}/package.json`, projectPackageJson); | ||
| } | ||
|
|
||
|
|
clarkerican
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #122