Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize map collection interfaces to handle all enum type arguments #638

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Generalize map collection interfaces to handle all enum type arguments #638

merged 3 commits into from
Jan 2, 2023

Conversation

halildurmus
Copy link
Owner

@halildurmus halildurmus commented Jan 2, 2023 •
edited
Loading

Fixes:

The changes to the core package are a little more painful: mostly because it introduces a circular dependency, since IMapView and other foundation classes use a couple of classes from Windows.Devices (BatteryReport and PedometerStepKind, most prominently). Ideally we wouldn't have to depend on the child packages from the foundation package, but I don't know if that's possible.

Originally posted by @timsneath in #634 (comment)

timsneath
timsneath approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@timsneath timsneath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's great! Thank you!

@timsneath timsneath merged commit 753e790 into main Jan 2, 2023
@timsneath timsneath deleted the generalize-enum-imap-keys branch January 2, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsneath timsneath timsneath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halildurmus @timsneath