Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: direct speaker notes view for development with live-reload #3032

Closed
RonnyPfannschmidt opened this issue Oct 13, 2021 · 7 comments
Closed

Comments

@RonnyPfannschmidt
Copy link

when using live-reload to work on slides
then a reload tends to close the slides,

i'd like to have the browser directly open the speaker view
so i can see changes without having to reopen the speaker view

@dabrahams
Copy link
Contributor

dabrahams commented Nov 23, 2021

Yes please. The speaker notes view not refreshing as I edit slides is a real time sink.

Duplicate of #2822?

@RonnyPfannschmidt
Copy link
Author

@dabrahams i want to have only the speaker view in the main window

My understanding is that this would not resolve the other issue, however it would render it ineffective as the live reload would be active on the single window speaker view instead of being active on the presentation view while the speakers window wouldn't have it

@dabrahams
Copy link
Contributor

@RonnyPfannschmidt I agree, this is not a duplicate, and I want exactly what you want. That would be a vast improvement.

@dabrahams
Copy link
Contributor

@hakimel I started to look at how to implement this but found the speaker notes plugin so complex that I wasn't sure where to start. If you could offer some guidance I might be able to come up with a PR.

@hakimel
Copy link
Owner

hakimel commented Feb 10, 2022

One option during development is to turn on the showNotes config option. This will show your speaker notes in the main window with live reloading support. It can enabled using a query param too .../demo.html?showNotes=true.
Screen Shot 2022-02-10 at 10 10 53

The best way I can think of to run the speaker view "directly" would be to embed it inside an iframe in the main window. That way the main window can still drive it using the same postMessage channel that it currently uses to control and communicate with the speaker view.

@hakimel
Copy link
Owner

hakimel commented Feb 10, 2022

I was able to find a way to address the issue in #2822 so that the speaker view will now remain open and live-reload when the presentation or its notes are edited.

I think that paired with the showNotes option mentioned above addresses this issue so I'm closing. Please let me know if you disagree though.

@hakimel hakimel closed this as completed Feb 10, 2022
@dabrahams
Copy link
Contributor

Knowing about the query param is actually enough to make showNotes a good solution for me. Thank you; perhaps that feature should be better advertised!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants