Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immediate task execution when defining test cases #492

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

farlee2121
Copy link
Collaborator

I.e. testTask and testCaseTask would start the task as soon as the test definition is created instead of when the test suite is run. This fixes a breaking change from how testTask used to work and a flaw of the new testCaseTask api. It is a breaking change to the testCaseTask api.

Thanks to @TheAngryByrd for noticing this issue on pr
#484

I.e. testTask and testCaseTask would start the task as soon as the test definition is created instead of when the test suite is run.
This fixes a breaking change from how testTask used to work and a flaw of the new testCaseTask api.
It is a breaking change to the testCaseTask api.
@farlee2121
Copy link
Collaborator Author

farlee2121 commented Mar 15, 2024

My thought is to release this as 10.2.1 and deprecate the 10.2.0 packages.
This release isn't backwards compatible with 10.2.0, but it fixes a backwards compatibility issue introduced by 10.2.0 and only breaks compatibility with endpoints introduced in that same release.

Thoughts?

Copy link
Contributor

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Funny enough I was hanging out with @AngelMunoz in discord and he hit this :)

@TheAngryByrd
Copy link
Contributor

My thought is to release this as 10.2.1 and deprecate the 10.2.0 packages. This release isn't backwards compatible with 10.2.0, but it fixes a backwards compatibility issue introduced by 10.2.0 and only breaks compatibility with endpoints introduced in that same release.

Thoughts?

Yeah I think that's a reasonable approach vs just bumping major.

@farlee2121 farlee2121 merged commit 76f104f into main Mar 15, 2024
3 checks passed
@farlee2121
Copy link
Collaborator Author

New version is out, 10.2.0 is deprecated with an explanatory message

@TheAngryByrd
Copy link
Contributor

Thank you!!

@farlee2121 farlee2121 deleted the bug-early-task-trigger branch April 12, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants