Support ValueTask and Async bindings in testTask #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farlee2121
commented
Mar 13, 2024
| @@ -243,6 +243,13 @@ module Tests = | |||
| | Focused -> ftestCaseTask name a | |||
| | Pending -> ptestCaseTask name a | |||
|
|
|||
| [<AutoOpen>] | |||
| module TestTaskExtensions = | |||
| type TestTaskBuilder with | |||
There was a problem hiding this comment.
Adding these overloads as extensions helps the compiler know to prioritize the original Task overload, which prevents breakage in existing code that may have implicitly typed an expression based on Bind originally only taking variations of Task.
|
Any thoughts from @ratsclub before I merge? |
ratsclub
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #488
Adds support for ValueTask, ValueTask, and Async bindings to the testTask expression.
This is accomplished through overloads of the Bind method.
I looked into inheriting the TaskBuilder, but it's constructor is hidden by the tasks.fsi file.