Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FsCheck3 support to release as a pre-release version of Expecto.FsCheck #461

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

farlee2121
Copy link
Collaborator

@farlee2121 farlee2121 commented Jun 21, 2023

This way we don't have to create a separate package. Should simplify adoption and trimming once FsCheck 3 reaches general release.

#450

Simplifies package adoption and triming after 3 reaches general release.
Also means we don't have to add another package.
@farlee2121
Copy link
Collaborator Author

@ratsclub Please let me know when you've merged your build system updates (or if you don't have time for it and want me to pick it up)

@farlee2121 farlee2121 merged commit 499c9c1 into main Jun 22, 2023
3 checks passed
@@ -13,7 +13,7 @@ nuget BenchmarkDotNet ~> 0.13.5
group FsCheck3
source https://api.nuget.org/v3/index.json

nuget FsCheck ~> 3.0.0-beta2
nuget FsCheck ~> 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this change is okay? running paket install is failing for me after this change because paket cannot find a suitable version of FsCheck

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot, you're right. I got hasty. Thanks for the save. I'll get a fix out asap

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could open a PR for #463 once you're done unless you've started work on it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've got this one though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Maybe I do need some help here. The security issues are plaguing this pr. I update the vulnerable packages to suggested versions, but it looks like WhiteSource keeps failing the check without re-evaluating. Clicking re-run just results in the same The contents of this commit did not trigger a Mend scan. message.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Maybe I do need some help here. The security issues are plaguing this pr. I update the vulnerable packages to suggested versions, but it looks like WhiteSource keeps failing the check without re-evaluating. Clicking re-run just results in the same The contents of this commit did not trigger a Mend scan. message.

I think the bot is stuck, your changes seem fine... mind if I open (yet another) PR to hopefully fix it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried closing the PR and opening a new one earlier, but it didn't work. Maybe we need to completely start over with a new branch and new commits. I'll check real quick

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, i suspect that it skips the scan because the initial commit is the same in both PRs you opened...

@JohnTheGr8
Copy link
Contributor

relevant message from paket:

Paket failed with
-> There was a version conflict during package resolution.
     Conflict detected:
      - Dependencies file requested package FsCheck: >= 3.0 < 4.0
      - Available versions:
        - (3.0.0-beta2, [https://api.nuget.org/v3/index.json])
        - (3.0.0-beta1, [https://api.nuget.org/v3/index.json])
        - (3.0.0-alpha5, [https://api.nuget.org/v3/index.json])
        - (3.0.0-alpha4, [https://api.nuget.org/v3/index.json])
        - (3.0.0-alpha3, [https://api.nuget.org/v3/index.json])
        - (3.0.0-alpha2, [https://api.nuget.org/v3/index.json])
        - (3.0.0-alpha1, [https://api.nuget.org/v3/index.json])
        - (2.16.5, [https://api.nuget.org/v3/index.json])
        - (2.16.4, [https://api.nuget.org/v3/index.json])
        - (2.16.3, [https://api.nuget.org/v3/index.json])
        - (2.16.2, [https://api.nuget.org/v3/index.json])
        - (2.16.1, [https://api.nuget.org/v3/index.json])
        - (2.16.0, [https://api.nuget.org/v3/index.json])
        - (2.15.3, [https://api.nuget.org/v3/index.json])
        - (2.15.2, [https://api.nuget.org/v3/index.json])
        - (2.15.1, [https://api.nuget.org/v3/index.json])
        - (2.15.0, [https://api.nuget.org/v3/index.json])
        - (2.14.6, [https://api.nuget.org/v3/index.json])
        - (2.14.5, [https://api.nuget.org/v3/index.json])
        - (2.14.4, [https://api.nuget.org/v3/index.json])
        - (2.14.3, [https://api.nuget.org/v3/index.json])
        - (2.14.2, [https://api.nuget.org/v3/index.json])
        - (2.14.1, [https://api.nuget.org/v3/index.json])
        - (2.14.0, [https://api.nuget.org/v3/index.json])
        - (2.13.0, [https://api.nuget.org/v3/index.json])
        - (2.12.1, [https://api.nuget.org/v3/index.json])
        - (2.12.0, [https://api.nuget.org/v3/index.json])
        - (2.11.0, [https://api.nuget.org/v3/index.json])
        - (2.10.10, [https://api.nuget.org/v3/index.json])
        - (2.10.9, [https://api.nuget.org/v3/index.json])
        - (2.10.8, [https://api.nuget.org/v3/index.json])
        - (2.10.7, [https://api.nuget.org/v3/index.json])
        - (2.10.6, [https://api.nuget.org/v3/index.json])
        - (2.10.5, [https://api.nuget.org/v3/index.json])
        - (2.10.4, [https://api.nuget.org/v3/index.json])
        - (2.10.3, [https://api.nuget.org/v3/index.json])
        - (2.10.2, [https://api.nuget.org/v3/index.json])
        - (2.10.1, [https://api.nuget.org/v3/index.json])
        - (2.10.0, [https://api.nuget.org/v3/index.json])
        - (2.9.2, [https://api.nuget.org/v3/index.json])
        - (2.9.1, [https://api.nuget.org/v3/index.json])
        - (2.9.0, [https://api.nuget.org/v3/index.json])
        - (2.9.0-rc3, [https://api.nuget.org/v3/index.json])
        - (2.9.0-rc2, [https://api.nuget.org/v3/index.json])
        - (2.9.0-rc1, [https://api.nuget.org/v3/index.json])
        - (2.8.2, [https://api.nuget.org/v3/index.json])
        - (2.8.1, [https://api.nuget.org/v3/index.json])
        - (2.8.0, [https://api.nuget.org/v3/index.json])
        - (2.7.2, [https://api.nuget.org/v3/index.json])
        - (2.7.1, [https://api.nuget.org/v3/index.json])
        - (2.7.0, [https://api.nuget.org/v3/index.json])
        - (2.6.3, [https://api.nuget.org/v3/index.json])
        - (2.6.2, [https://api.nuget.org/v3/index.json])
        - (2.6.1, [https://api.nuget.org/v3/index.json])
        - (2.6.0, [https://api.nuget.org/v3/index.json])
        - (2.5.0, [https://api.nuget.org/v3/index.json])
        - (2.4.0, [https://api.nuget.org/v3/index.json])
        - (2.3.0, [https://api.nuget.org/v3/index.json])
        - (2.2.5, [https://api.nuget.org/v3/index.json])
        - (2.2.4, [https://api.nuget.org/v3/index.json])
        - (2.2.3, [https://api.nuget.org/v3/index.json])
        - (2.2.2, [https://api.nuget.org/v3/index.json])
        - (2.2.1, [https://api.nuget.org/v3/index.json])
        - (2.2.0, [https://api.nuget.org/v3/index.json])
        - (2.1.0, [https://api.nuget.org/v3/index.json])
        - (2.0.7, [https://api.nuget.org/v3/index.json])
        - (2.0.6, [https://api.nuget.org/v3/index.json])
        - (2.0.5, [https://api.nuget.org/v3/index.json])
        - (2.0.5-a1507312207, [https://api.nuget.org/v3/index.json])
        - (2.0.4, [https://api.nuget.org/v3/index.json])
        - (2.0.3, [https://api.nuget.org/v3/index.json])
        - (2.0.2, [https://api.nuget.org/v3/index.json])
        - (2.0.1, [https://api.nuget.org/v3/index.json])
        - (2.0.1-rc1, [https://api.nuget.org/v3/index.json])
        - (2.0.0, [https://api.nuget.org/v3/index.json])
        - (2.0.0-alpha, [https://api.nuget.org/v3/index.json])
        - (1.0.4, [https://api.nuget.org/v3/index.json])
        - (1.0.3, [https://api.nuget.org/v3/index.json])
        - (1.0.2, [https://api.nuget.org/v3/index.json])
        - (1.0.1, [https://api.nuget.org/v3/index.json])
        - (1.0.0, [https://api.nuget.org/v3/index.json])
        - (0.9.4, [https://api.nuget.org/v3/index.json])
        - (0.9.3, [https://api.nuget.org/v3/index.json])
        - (0.9.2, [https://api.nuget.org/v3/index.json])
        - (0.9.1, [https://api.nuget.org/v3/index.json])
        - (0.9.0.1, [https://api.nuget.org/v3/index.json])
        - (0.9.0, [https://api.nuget.org/v3/index.json])
        - (0.8.3, [https://api.nuget.org/v3/index.json])
        - (0.8.2, [https://api.nuget.org/v3/index.json])
        - (0.8.1, [https://api.nuget.org/v3/index.json])
        - (0.8.0, [https://api.nuget.org/v3/index.json])
        - (0.7.1, [https://api.nuget.org/v3/index.json])

     Please try to relax some conditions or resolve the conflict manually (see http://fsprojects.github.io/Paket/nuget-dependencies.html#Use-exactly-this-version-constraint).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants