-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FsCheck3 support to release as a pre-release version of Expecto.FsCheck #461
Conversation
Simplifies package adoption and triming after 3 reaches general release. Also means we don't have to add another package.
4ed4e51
to
3721e7e
Compare
@ratsclub Please let me know when you've merged your build system updates (or if you don't have time for it and want me to pick it up) |
@@ -13,7 +13,7 @@ nuget BenchmarkDotNet ~> 0.13.5 | |||
group FsCheck3 | |||
source https://api.nuget.org/v3/index.json | |||
|
|||
nuget FsCheck ~> 3.0.0-beta2 | |||
nuget FsCheck ~> 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this change is okay? running paket install
is failing for me after this change because paket cannot find a suitable version of FsCheck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, you're right. I got hasty. Thanks for the save. I'll get a fix out asap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could open a PR for #463 once you're done unless you've started work on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've got this one though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Maybe I do need some help here. The security issues are plaguing this pr. I update the vulnerable packages to suggested versions, but it looks like WhiteSource keeps failing the check without re-evaluating. Clicking re-run just results in the same The contents of this commit did not trigger a Mend scan.
message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Maybe I do need some help here. The security issues are plaguing this pr. I update the vulnerable packages to suggested versions, but it looks like WhiteSource keeps failing the check without re-evaluating. Clicking re-run just results in the same
The contents of this commit did not trigger a Mend scan.
message.
I think the bot is stuck, your changes seem fine... mind if I open (yet another) PR to hopefully fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried closing the PR and opening a new one earlier, but it didn't work. Maybe we need to completely start over with a new branch and new commits. I'll check real quick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, i suspect that it skips the scan because the initial commit is the same in both PRs you opened...
relevant message from paket:
|
This way we don't have to create a separate package. Should simplify adoption and trimming once FsCheck 3 reaches general release.
#450