Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustc version #690

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Bump rustc version #690

merged 6 commits into from
Jun 3, 2024

Conversation

Nadrieril
Copy link
Collaborator

My reasoning is as follows: we need an up-to-date rust-overlay in order
to access recent nightlies. Currently we follow crane's rust-overlay,
but recent versions of crane don't have a rust-overlay input anymore. So
we'll need to have rust-overlay as input like this eventually anyway.
Hence I did this without even updating crane because there was no need.
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, looks good to me!
The nix change makes sense indeed :)

@Nadrieril Nadrieril marked this pull request as ready for review May 29, 2024 08:23
@Nadrieril
Copy link
Collaborator Author

Charon is ready

@Nadrieril Nadrieril added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
This is not breaking anything on hax, but unbreaks `serde`: serde-rs/serde#2734
@W95Psp W95Psp enabled auto-merge May 29, 2024 09:30
@W95Psp W95Psp added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@W95Psp W95Psp added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@W95Psp W95Psp added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 29, 2024
@W95Psp W95Psp added this pull request to the merge queue Jun 3, 2024
Merged via the queue into hacspec:main with commit 3444df7 Jun 3, 2024
12 of 13 checks passed
@Nadrieril Nadrieril deleted the update-rustc branch June 3, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants