Implement a new version/pre-release selector #762
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,3 +68,11 @@ export const repositoryDownloadVersion = async ( | |
| repository: repository, | ||
| version, | ||
| }); | ||
|
|
||
| export const repositoryReleases = async (hass: HomeAssistant, repositoryId: string) => | ||
| hass.connection.sendMessagePromise< | ||
| { tag: string; name: string; published_at: string; prerelease: boolean }[] | ||
| >({ | ||
| type: "hacs/repository/releases", | ||
| repository_id: repositoryId, | ||
| }); | ||
|
Comment on lines
+72
to
+78
There was a problem hiding this comment. Tip Codebase Verification Add error handling for Currently, the
Example: async _fetchReleases() {
if (this._releases !== undefined) {
return;
}
try {
this._releases = await repositoryReleases(this.hass, this._repository!.id);
} catch (error) {
console.error("Failed to fetch releases:", error);
this._error = error;
}
}Remember, even code needs a safety net sometimes! 🐰✨ Analysis chainVerify error handling and function usage. The function Alright, it looks like our previous search came up empty. Let's widen our net and see if we can catch any fish this time. We'll search through both JavaScript and TypeScript files and grab a bit more context around each instance of Alright, it looks like we found where Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify all function calls to `repositoryReleases` handle errors and match the expected response structure.
# Test: Search for the function usage. Expect: Proper error handling and matching response structure.
rg --type js -A 5 $'repositoryReleases'
Length of output: 38 Script: #!/bin/bash
# Description: Verify all function calls to `repositoryReleases` handle errors and match the expected response structure.
# Test: Search for the function usage in both JavaScript and TypeScript files. Expect: Proper error handling and matching response structure.
rg --type-add 'ts:*.{ts,tsx}' --type-add 'js:*.{js,jsx}' -tjs -tts -A 10 'repositoryReleases'
Length of output: 2402 Script: #!/bin/bash
# Description: Extract more lines around the usage of `repositoryReleases` in `hacs-download-dialog.ts` to verify error handling.
# Test: Extract 20 lines before and after the usage of `repositoryReleases` in `hacs-download-dialog.ts`.
rg --type ts -A 20 -B 20 'repositoryReleases' src/components/dialogs/hacs-download-dialog.ts
Length of output: 3207 |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,6 +75,13 @@ | |
| "dialog_download": { | ||
| "type": "Type", | ||
| "url": "URL", | ||
| "will_download_version": "Version {ref} will be downloaded", | ||
| "will_download_commit": "Commit {ref} will be downloaded", | ||
| "different_version": "Need a different version?", | ||
| "fetching_releases": "Fetching releases...", | ||
| "no_releases": "No releases found", | ||
| "release": "Release", | ||
| "release_warning": "It is not advised to use this section to do a rollback, restore a backup instead.", | ||
| "restart": "Remember that you need to restart Home Assistant before changes to integrations (custom_components) are applied.", | ||
| "selector_note": "The version selector will be removed in a future release. If you need to install a specific version, you can do so by using the service call for update entities.", | ||
| "note_downloaded": "When downloaded, this will be located in {location}", | ||
|
|
@@ -165,4 +172,4 @@ | |
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address forbidden non-null assertion.
Replace the non-null assertion with the optional chain operator for safer runtime checks.
Committable suggestion
Tools
Biome