Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvements #216

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Build improvements #216

merged 9 commits into from
Mar 12, 2024

Conversation

bonddim
Copy link
Contributor

@bonddim bonddim commented Mar 4, 2024

  • Add frontend build to Dockerfile (and remove builded from repo)
  • Use cross-platform docker build
  • Use golang-alpine image for build
  • Refactor docker-publish workflow
  • Update actions versions
  • Add dependabot config for actions and go
  • Update Vite to fix CVE-2024-23331
  • Add curl,iptables,nftables into final image to use with Pre* and Post* interface actions

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@h44z h44z merged commit 2de438a into h44z:master Mar 12, 2024
4 checks passed
@h44z
Copy link
Owner

h44z commented Mar 12, 2024

nice, thank you!

@bonddim bonddim deleted the build-improvements branch March 12, 2024 22:46
Copy link

@pautiina pautiina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this commit 6fb6dc0 - package not build

# make build
internal/app/api/core/assets.go:15:12: pattern frontend-dist/assets/*: no matching files found
cp scripts/wg-portal.service dist
CGO_ENABLED=0 go build -o dist/wg-portal \
 -ldflags "-w -s -extldflags \"-static\" -X 'github.com/h44z/wg-portal/internal/server.Version=-'" \
 -tags netgo \
 cmd/wg-portal/main.go
internal/app/api/core/assets.go:15:12: pattern frontend-dist/assets/*: no matching files found
make: *** [Makefile:78: build] Помилка 1

@bonddim
Copy link
Contributor Author

bonddim commented Mar 13, 2024

@pautiina, correct
Builded frontend files were deleted from the repository.
Run

make frontend
make build

@pautiina
Copy link

make build

Works.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants