Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alpine base image #205

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Use Alpine base image #205

merged 1 commit into from
Dec 23, 2023

Conversation

HPPinata
Copy link
Contributor

wgquick (apparently) depends on bash and openresolv.

Without those packages removing an Interface is impossible and causes an error message to appear in the webui:

  • No Bash: exec complains about "bash no such file in $PATH"
  • No openresolv: resolvconf -f -d interface returns with error 127

Not having a Shell in the container also makes debugging a lot more annoying.

This enables deletion of interfaces in the webui, eases debugging and only adds about 3MB in size.

wgquick (apparently) depends on bash and openresolv.

Without those packages removing an Interface is impossible and causes an error message to appear in the webui:
- No Bash: exec complains about "bash no such file in $PATH"
- No openresolv: resolvconf -f -d *interface* returns with error 127

Not having a Shell in the container also makes debugging a lot more annoying.

This enables deletion of interfaces in the webui, eases debugging and only adds about 3MB in size.
@HPPinata
Copy link
Contributor Author

HPPinata commented Dec 21, 2023

Testing environment was the wgportal/wg-portal:latest docker image running on top of OpenSUSE MicroOS in an x86_64 VM using the official docker and docker-compose packages with cap_add: - NET_ADMIN and network_mode: host set. I even tested privileged: true with no change in observed behaviour.

I tested both removal of imported and new interfaces, behaviour is consistent between both cases (does not work without changes, works after adding bash and openresolv). I also tested whether openresolv needed to be installed in the container, on the host, on both or neither system. Result: installing bash and openresolv just in the container is sufficient
No build errors or other issuses were observed after applying the changes. No other changes were made to the system or install.

The configuration file was quite minimal and based on the config.yml.sample with the auth section removed.
Import existing was changed between true and false (with a full docker system prune -a -f --volumes in between to test removal of preexisting vs. completely new interfaces:

advanced:
  log_level: trace

core:
  admin_user: user@example.net
  admin_password: SecurePassword
  import_existing: false

web:
  external_url: https://my.external.url
  request_logging: true

Copy link
Owner

@h44z h44z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm =)

@h44z h44z merged commit 4a0fcfb into h44z:master Dec 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants